531786 - Application Name (Fennec) should not be hardcoded in installer file (setup.ini)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[dynamis (Tomoya ASAI)]

Currently Fennec's installer file have hard corded brand names within setup.ini:
http://hg.mozilla.org/mobile-browser/file/tip/locales/en-US/installer/setup.ini

But for official releases, we must change it from "Fennec" to "Firefox".
They should use $BrandShortName (or $AppShortName) as Firefox do.

This have l10n impact and we should handle this soon.

Comment 1

[dynamis (Tomoya ASAI)]

Requesting blocking-fennec.
If setup.ini will not be used in official build, reject blocking request.

Comment 3

[Alex Pakhotin (:alexp)]

Attachment: Fix

Use %MOZ_APP_DISPLAYNAME% in setup.ini, and replace it from locales/Makefile.

Comment 4

[Robert Strong (they/them - no direct email)]

Alex, I just saw this request and am unsure exactly when I'll be able to get to it. It would normally be quick for this type of change but I haven't had a chance to look at how the recent changes to packaging made by ted and axel work yet. Since it appears that all of the changes are under mobile you might get a quicker review by someone on the mobile team if this is time sensitive.

Comment 5

[Robert Strong (they/them - no direct email)]

btw: applying the patch and doing an incremental build didn't replace MOZ_APP_DISPLAYNAME in the installer for me when testing with an emulator... perhaps a clobber is required?

Comment 6

[Robert Strong (they/them - no direct email)]

Alex, I did a clobber then make installer and it appears to be using the setup.ini from the src dir and not the preprocessed one.

Comment 7

[Alex Pakhotin (:alexp)]

Hey, nice catch! Somehow I missed that. That's what reviews are for! :)
Yes, installer Makefile got the setup.ini from the source dir because we didn't copy it anywhere before. It has to be updated too.

Comment 8

[Alex Pakhotin (:alexp)]

Attachment: Updated fix

Added installer Makefile change to the patch. It gets the processed setup.ini and packs it into a setup executable.

Comment 9

[Robert Strong (they/them - no direct email)]

I noticed that the destination for the setup.ini is dist/bin... I personally prefer not cluttering up this directory when possible. We use other dirs for Firefox (sometimes in the root of the obj-dir, another time under browser/installer/windows/instgen, and yet other times under dist/install.

Comment 10

[Alex Pakhotin (:alexp)]

setup.ini is used by uninstall.exe, both of them go into the main Fennec directory on a device (which is based on dist/bin). Any suggestions on a more appropriate location for that are welcomed.

Comment 11

[Robert Strong (they/them - no direct email)]

I forgot it was read by uninstall.exe and if it is actually part of the distribution then this is fine.

Comment 12

[Robert Strong (they/them - no direct email)]

Comment on attachment 416299 [details] [diff] [review]
Updated fix

Talked with Ted about the LOCALE_MERGEDIR and I'm comfortable +'ing that part as well. r=me as long as you've also built / tested this.

Comment 13

[Robert Strong (they/them - no direct email)]

btw: the l10n tinderboxen won't catch this change since the names aren't changing. One thing you can do is check for the existence of part of the string (e.g. Fennec) similar to
http://mxr.mozilla.org/mozilla1.9.1/source/toolkit/mozapps/installer/windows/nsis/check-locales.pl

though I'd recommend using python

Comment 14

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/mobile-browser/rev/942cf00afc9c

Comment 15

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

what is checkin-needed here?

Comment 16

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #15)
> what is checkin-needed here?

Nothing. Sorry.