531887 - Make editor comment system more useful by making it contextual to versions; add flags

Status: RESOLVED WONTFIX

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect, P3)

Description

[Jorge Villalobos [:jorgev] (he/him)]

The current editor commenting system isn't very useful, and it shows because it's barely used. There are a few things that editors think should be changed in order to make it a more handy tool:

1) Remove the current global comment behavior and make it contextual to versions. An editor should be able to comment on the latest version, and the comment should appear in the revision history, similar to information requests. Editors should be able to reply to these comments.
2) Show a flag in the queue UI when the current version has comments. Maybe a comment count would be good too.

Comment 1

[Scott McCammon [:mccammos]]

(In reply to comment #0)
> 1) Remove the current global comment behavior and make it contextual to
> versions. An editor should be able to comment on the latest version, and the
> comment should appear in the revision history, similar to information requests.
> Editors should be able to reply to these comments.

This is how the current implementation is supposed to work. Do you have an add-on that shows global behavior?

> 2) Show a flag in the queue UI when the current version has comments. Maybe a
> comment count would be good too.

This seems useful. We could add a comment icon in the flags column of the queue.

Comment 2

[Jorge Villalobos [:jorgev] (he/him)]

(In reply to comment #1)
> (In reply to comment #0)
> > 1) Remove the current global comment behavior and make it contextual to
> > versions. An editor should be able to comment on the latest version, and the
> > comment should appear in the revision history, similar to information requests.
> > Editors should be able to reply to these comments.
> 
> This is how the current implementation is supposed to work. Do you have an
> add-on that shows global behavior?

To clarify: I'm referring to the comments that appear at the very bottom of the page and only Editors can see and reply to, not Information requests which are done between editors and authors.
I'm not sure if these comments are associated to versions in the DB, all I know is that they all appear at the bottom of the page, with no link to the version review history. Point 1 is about integrating the comments into this history.

Comment 3

[Scott McCammon [:mccammos]]

(In reply to comment #2)
> I'm not sure if these comments are associated to versions in the DB, all I know
> is that they all appear at the bottom of the page, with no link to the version
> review history. Point 1 is about integrating the comments into this history.

Yes, the editor comments are associated with a version in the DB. Links to view comments for other versions are in the Item History table.

Comment 4

[Wil Clouser [:clouserw]]

The mini-forum will be revisited later from a higher level perspective

Comment 5

[Jorge Villalobos [:jorgev] (he/him)]

Reclassifying editor bugs and changing to a new whiteboard flag. Spam, spam, spam, spam...