Closed
Bug 5319
Opened 26 years ago
Closed 26 years ago
PP: apprunner crashes on prefs file with commented out pref setting
Categories
(Core :: JavaScript Engine, defect, P2)
Tracking
()
VERIFIED
FIXED
M7
People
(Reporter: slogan, Assigned: rogerl)
Details
If my ~/.mozilla/prefs50.js file is:
// Netscape User Preferences
// This is a generated file! Do not edit.
user_pref("general.startup.browser", false);
//user_pref("nglayout.widget.mode", 2);
user_pref("general.startup.calendar", true);
user_pref("general.startup.editor", true);
user_pref("general.startup.mail", true);
I crash when I go to edit/preferences. If I remove the commented out user_pref
line for widget mode, I don't crash. It doesn't crash while in gdb either, at
least, it hasn't for me. Probably some bug parsing comments.
Assignee: don → mcmullen
Component: Apprunner → libPref
Priority: P3 → P2
Target Milestone: M5
Re-assigned to mcmullen; set target milestone to M5; changed component to
libPref and priority to P2.
John, is this fixable for M5 or should it wait?
Assignee: mcmullen → mccabe
Status: ASSIGNED → NEW
Component: libPref → JavaScript
I'm changing the component to JavaScript, and reassigning it to mccabe, the
alleged module owner.
Updated•26 years ago
|
Summary: apprunner tubes on prefs file with commented out pref setting → apprunner crashes on prefs file with commented out pref setting
Comment 8•26 years ago
|
||
The current state of this bug on Linux is even worse than the original report.
You crash every time opening up preferences from the edit menu unless you start
your session by manually creating a completely empty (no comments even) prefs
file. And even then every subsequent session will crash in prefs because it
opening the preference UI adds in the comments.
I will wait till we have Mac/PC builds today before verifying on those
platforms.
Comment 9•26 years ago
|
||
This was using noon builds from 5/6.
Updated•26 years ago
|
Summary: apprunner crashes on prefs file with commented out pref setting → PP: apprunner crashes on prefs file with commented out pref setting
Comment 10•26 years ago
|
||
On Mac/Windows, the commented prefs are simply stripped out of the file and no
crash occurs, so marking PP:.
Assignee | ||
Updated•26 years ago
|
Assignee: mccabe → rogerl
Assignee | ||
Comment 11•26 years ago
|
||
Offloading from mccabe.
Assignee | ||
Updated•26 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 12•26 years ago
|
||
Sigh, I finally got a current build up and running on a linux machine but can't
reproduce this behaviour. Have you seen it recently ?
Updated•26 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
Comment 13•26 years ago
|
||
yes, looks fixed. Marking resolved. Comments are stripped out - is this the
correct behavior?
Comment 14•26 years ago
|
||
Yes, it's regenerated whenever the prefs window closes, or the app quits, etc.
The comments are merely skipped on reading, so there's no way they could be
written out again.
Updated•26 years ago
|
Status: RESOLVED → VERIFIED
Comment 15•26 years ago
|
||
k, marking verified fixed
Comment 16•26 years ago
|
||
Changing component to "Javascript Engine". "Javascript" component is being
retired.
You need to log in
before you can comment on or make changes to this bug.
Description
•