53198 - Mac-Need UI for disabling TLS

Status: VERIFIED FIXED

(Core Graveyard :: Security: UI, defect, P3)

Description

[John Unruh]

We need a way to disable TLS in the Security Manager UI. The above URL can be 
reached if TLS is disabled.

Comment 1

[David P. Drinan]

Setting keyword rtm.

Comment 2

[David P. Drinan]

Attachment: Patch to pass the new TLS pref to PSM.

Comment 3

[David P. Drinan]

Javi,

Please review my patch to psm-glue to pass the TLS pref to PSM.

Comment 4

[Javier Delgadillo]

patch is good.  r=javi

Comment 5

[David P. Drinan]

Adding rtm+ to whiteboard.

Comment 6

[Phil Peterson]

PDT would like an explanation of what user-level feature is broken if we don't
take this patch. We're really focused on crash/data loss bugs right now.

Comment 7

[Michael La Guardia]

changing to rtm need info

Comment 8

[Javier Delgadillo]

There are some SSL servers out there that have a non-compliant implementation of 
TLS.  Suddenly, when a user who could go to the server before when upgrading to 
N6 will not be able to access the site because PSM tries to negotiate using the 
latest version of the protocol but the server does not correctly implement the 
detection which is intended to prevent a version rollback attack.  By adding 
this UI, the user can then go and talk to their bank or what not for the time 
being.  Without this UI, N6 will not work at all with all of the non-compliant 
servers out there.  Adding this UI at least gives N6 the possibility of 
revertingto an earlier version of SSL that will work with those sites.

Comment 9

[Scott Collins]

This patch looks reasonable other than two nits: (a) looks like tabs instead of
spaces at least in one place; and (b) prefer pre-increment over post- except
where idiom demands (e.g., in idiomatic character-copying loops).

My only other problem in this review is that, though the patch itself is small
and reasonable ... it's difficult to see what ramifications it has that I need
to be aware of.  Who is the client of this pref; now that it is in place, where
will the behavior change?

Comment 10

[Scott Collins]

I see now, this preference is exploited by the code in bug #53810.  Good.  Fix
the tabs (if that's what your formatting problem is); I'd _like_ you to change
the post-increment to a pre-increment (and make this habit).  After that, sr=scc.

Comment 11

[David P. Drinan]

Made the changes Scott Collins recommended and marking [rtm+].

Comment 12

[selmer (gone)]

rtm++

Comment 13

[John Unruh]

Fixed. The UI is functional in the PSM 1.3 10/12 server on Win98. I can visit 
the above URL when TLS is turned off. Will verify on all platforms when the 
ability to turn off TLS in the Security Manager UI is in the commercial branch 
builds.

Comment 14

[John Unruh]

Verified on Win98 and Linux trunk 10/18 builds. Will verify on branch builds
later today. Verifying on Mac is blocked by bug 57081.

Comment 15

[John Unruh]

Verified on Win98 and Linux branch 10/18 builds. Setting OS to Mac.

Comment 16

[John Unruh]

Verified in the 10/29 branch commercial build.

Comment 17

[John Unruh]

Mass changing Security:Crypto to PSM

Comment 18

[John Unruh]

Mass changing Security:Crypto to PSM