532040 - gloda: chromedir! philor: You keep using that word. I do not think it means what you think it means.

Status: RESOLVED FIXED

(Thunderbird :: Search, defect)

Description

[Phil Ringnalda (:philor)]

Attachment: rm

You only include global.dtd when you are going to use &locale.dir;, that's all it gives you.

You only use &locale.dir; for two things: to set the dir attribute on the body element in XHTML, and to set the chromedir attribute on an XUL element when you then plan on using that in CSS, in 1.9.1 or earlier where :-moz-locale-dir didn't exist, to do things differently for ltr and rtl.

Since nothing is trying to style searchInput or PopupGlodaAutocomplete based on their chromedir, I'm going to guess that they just sort of wandered into the glodasearch branch of their own accord, without anyone ever really feeling any actual need for them.

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 415343 [details] [diff] [review]
rm

This was likely the nefarious work of copy and paste.

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

Also, thank you very much for explaining why we don't want it.

Comment 3

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/comm-central/rev/ae769efac6ed