532060 - Always force components.list in partial updates (to reset content)

Status: RESOLVED FIXED

(Mozilla Messaging Graveyard :: Release Engineering, defect)

Description

[Mark Banner (:standard8)]

+++ This bug was initially created as a clone of Bug #528457 +++

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a1pre) Gecko/20091112 Minefield/3.7a1pre (.NET CLR 3.5.30729)

As said on bug 519357 we want to update the components.list file for each update we roll-out to users. This seems not to work at the moment. If you modify or remove that file from the components folder we never revert the content to the original state or recreate that file.

It looks like that the mar files don't include a patch for that file for partial and complete updates.

---- end clone ----

We won't need attachment 413266 [details] [diff] [review] from bug 528457 as that should be included in our builds already via the mozilla-* part.

We will need attachment 413267 [details] [diff] [review] but we can only do that when we set up our patcher configs for 3.1.

Hence marking as blocking to keep track and ensure we do this.

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

It looks to me like we don't actually require this for 3.1a1, so I've removed the target milestone and set blocking to needed+.  Feel free to adjust if you wish.

Comment 2

[Mark Banner (:standard8)]

(In reply to comment #1)
> It looks to me like we don't actually require this for 3.1a1, so I've removed
> the target milestone and set blocking to needed+.  Feel free to adjust if you
> wish.

Agreed we don't need this for alpha. Though we should include it for beta so that any developers trying to do the wrong thing will find out quickly.

Comment 3

[Mark Banner (:standard8)]

Attachment: Possible Fix

I think this is right. This copies the 1.9.1 patcher config for Thunderbird to 1.9.2 and changes the data to include just alpha 1 and the pending beta 1 release.

In addition it adds the required "force" lines so the components.list will get reset on each upgrade.

Comment 4

[Philippe M. Chiasson (:gozer)]

One question, do we need to worry about this for nightly builds ?

Comment 5

[Mark Banner (:standard8)]

(In reply to comment #4)
> One question, do we need to worry about this for nightly builds ?

That was/is attachment 413266 [details] [diff] [review] that's a core change already landed. I've just checked nightly updates on 3.1 and they are clearing down components.list just fine.

Comment 6

[Philippe M. Chiasson (:gozer)]

Attachment: Better Fix

Fixed a few typos in the original file, double-checked the build ids were correct and successfully ran patcher --download on this. Worked, and complained about 3.1b1 not existing, but that's expected.

Comment 7

[Dan Mosedale (:dmosedale, :dmose)]

gozer, do you feel that comment 6 consistutes your reviewed version of the patch and is ready to land, or would you like Standard8 to review it first?

Comment 8

[Philippe M. Chiasson (:gozer)]

(In reply to comment #7)
> gozer, do you feel that comment 6 consistutes your reviewed version of the
> patch and is ready to land,

Yes, certainly. Especially since this will only become used once I run the first updates for 3.1.x, so if something doesn't work quite right, it's going to be right in my face.

> or would you like Standard8 to review it first?

Not needed, IMO.

Comment 9

[Mark Banner (:standard8)]

This landed at some stage:

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/tools/patcher-configs/moz192-thunderbird-branch-patcher2.cfg&rev=&cvsroot=/cvsroot&rev=1.1

We need to make sure we verify this bug for 3.1b1 (so that we know the config is working correctly).