User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:184.108.40.206) Gecko/20091102 Firefox/3.5.5 Build Identifier: With the checkin for bug 527980, configure fails on Darwin/X11: checking for fontconfig/fcfreetype.h... no configure: error: Can't find header fontconfig/fcfreetype.h. *** Fix above errors and then restart with "make -f client.mk build" make: *** [configure] Error 1 Config.log says: configure:22269: checking for fontconfig/fcfreetype.h configure:22279: gcc-4.2 -arch x86_64 -E -isysroot /Developer/SDKs/MacOSX10.5.sdk -I/sw64/include/freetype2 -I/sw64/include conftest.c >/dev/null 2>conftest.out configure:22275:35: error: fontconfig/fcfreetype.h: No such file or directory configure: failed program was: #line 22274 "configure" #include "confdefs.h" #include <fontconfig/fcfreetype.h> And fontconfig/fcfreetype.h is in /usr/X11/include/fontconfig/fcfreetype.h Reproducible: Always Adding $XCFLAGS to $CPPFLAGS in the relevant configure.in test allows the build to finish successfully.
Created attachment 415407 [details] [diff] [review] adds XCFLAGS to CPPFLAGS in configure
wanted, but certainly not blocking or urgent given the current schedule
Perhaps I should have used pkg-config. For future reference, does that work as expected on Darwin?
[nieder] $ pkg-config --cflags fontconfig -I/usr/X11/include
Comment on attachment 415407 [details] [diff] [review] adds XCFLAGS to CPPFLAGS in configure Oops. That should have been an approval request for 1.9.2 since the patch from bug 527980 landed there as well (although having it wanted is of course nice too :)
Comment on attachment 415407 [details] [diff] [review] adds XCFLAGS to CPPFLAGS in configure a192=beltzner, post-hoc, reed has been appropriately scolded.