532117 - Review string for correctness

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Localization, defect, P4)

Description

[Wil Clouser [:clouserw]]

From the mailing list:

msgid "<strong>Caution:</strong> Beta versions of this add-on have not been reviewed by Mozilla.  Once you install a beta version you will continue to receive beta updates from this developer.  To switch back to the normal version of this add-on, click on the &ldquo;Add to Firefox&rdquo; button at the top of this page."

Is the application name always "Firefox"?

Comment 1

[Wil Clouser [:clouserw]]

Since this bug is probably for me, while I'm at it please change "show Firefox-only add-ons" to "show only Firefox add-ons".  thx.

Comment 2

[Jeff Balogh (:jbalogh)]

Dear future Wil:

Any app can have beta versions, so Firefox should not be hardcoded.

Comment 3

[Wil Clouser [:clouserw]]

Both strings changed in r58075 and merged to .po files in r58076

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; Firefox-specific mention is removed, and grammatically, it looks fine to me.

Comment 5

[Jesper Kristensen]

(In reply to comment #1)
> Since this bug is probably for me, while I'm at it please change "show
> Firefox-only add-ons" to "show only Firefox add-ons".  thx.

By doing this, you made the string untranslatable, because the string is already used as "show only English add-ons", so in my language the string reads "show only add-ons in the Firefox language". Please add relevant msgctxt.

Here is the .po file with conflicting comments:

#. L10n: %1$s is an application name like "Firefox"
#. L10n: %1$s is the user's current language.
#. E.g. "English (US)"
#: views/elements/amo2009/addons/list_options.thtml:115 views/layouts/amo2009.thtml:258
#, php-format
msgid "show only %1$s add-ons"
msgstr "show only %1$s add-ons"

(ps. The QA contact doesn't seem to match the component of the bug)

Comment 6

[Wil Clouser [:clouserw]]

done in r59101