532164 - FF3.6 does not use proper GTK font color with dark theme

Status: NEW

(Core :: Widget: Gtk, defect)

Description

[Derick Eisenhardt]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2b4) Gecko/20091124 Firefox/3.6b4
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2b4) Gecko/20091124 Firefox/3.6b4

I use Gnome/GTK, and I have a dark theme, with light text. When I tried out the new Firefox 3.6.beta4 today I noticed I could not read any of the menus on the top toolbar. I'm guessing that they are ignoring my theme's font colors and just rendering in a default black, but since my theme is black they are not visible.

When I click on a menu item the drop down shows with the correct colors (as demonstrated in the attached screenshot).

For reference, I am running Ubuntu 8.04 LTS (Hardy) - 32bit x86, with Gnome 2.22.3, and I use the SlicknesS GTK theme.

I have uploaded a screenshot for demonstration here: http://www.flickr.com/photos/zephyrxero/4151113256/sizes/l/

Let me know if there's any more info I can provide or help with.

Reproducible: Always

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Do you have any problems by using the default theme? If not this bug is invalid and you should file it against the theme or simply contact the author.

Comment 2

[Derick Eisenhardt]

Henrik, I think you have misread my post.....I AM using the default theme in Firefox....this is stock FF, no themes nor personas....

It is my system theme...for Gnome/GTK that is having a problem with FF. FF3.0 & 3.5 do not have a problem with it, but FF 3.6 does. So, it is clearly a bug in FF, not the theme.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Oh thanks. I miss read that. Sorry. CC'ing Karl to this bug who could have an idea. 

Derick, would you be able to check for a regression range? That means when this bug has been started to appear for previous Firefox 3.6 beta releases? Can you download and install those? That would be great.

Which dark theme are you referring to? I only have the dark room theme installed on Ubuntu 9.10 and cannot see this issue.

Comment 4

[Derick Eisenhardt]

Attachment: Screenshot demonstrating bug 532164

Bug is still present in 3.6-beta5

@Henrik: it is the 'SlicknesS' GTK theme: http://www.gnome-look.org/content/show.php/SlicknesS?content=71993
and I am using Ubuntu 8.04 (Hardy)

I'll try and go back and check what version it first appears in some time soon ;)

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Derick, are other GTK applications affected too or is it Firefox only? I wonder if this could be a problem with the mentioned GTK theme.

Comment 6

[Derick Eisenhardt]

(In reply to comment #5)
> Derick, are other GTK applications affected too or is it Firefox only? I wonder
> if this could be a problem with the mentioned GTK theme.

I've been using this theme for about 2 years and have never had this problem before with any other software. As stated in the original report, Firefox 3.0 & 3.5 do not have this problem.

Comment 7

[Derick Eisenhardt]

Ok, went back and found some old builds. The bug is present all the way back thru 3.6.alpha1 (Namoroka).

Comment 8

[Karl Tomlinson (:karlt)]

Possibly a change from bug 496454.

Comment 9

[Michael Ventnor]

Definitely a regression from that bug, the problem is that bug fixed the same problem for a lot of other, more popular themes.
I don't know what GTK as a whole uses as the normal fg menubar text colour, but this theme only sets fg PRELIGHT and ACTIVE to light colours on the menubar.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

As described on the home page of the theme you have to copy the userChrome.css into your profile to make the theme work. Derick, can you please move this file temporary away and check if that changes something for you after a restart of Firefox?

Comment 11

[Derick Eisenhardt]

Yes, the userChrome.css workaround does fix the problem. I'm still confused as why this was not required for 3.0 - 3.5, but now is again with 3.6. I never thought to do that as the instructions were for 2.0

As I've yet to be able to replicate the bug with any other themes either and this css trick has fixed it, I guess it's safe to say this is specific to this theme and not a general problem.

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Derick, could you please attach the userChrome.css file to this bug?

Comment 13

[Derick Eisenhardt]

Attachment: userChrome.css from SlicknesS GTK theme

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Karl, can we safely mark it as invalid then? With 3.6 we are using native colors now, right?

Comment 15

[Karl Tomlinson (:karlt)]

Henrik, I don't think we know enough to mark this invalid.  The symptoms seem to suggest that Mozilla is doing something different to what GTK does for its menus.
The userChrome.css is probably really a workaround for this different behavior in Mozilla.  (It is useful to know there is a workaround though, and that most other themes don't seem to have this problem.)

Comment 16

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Karl, you are right. We should check for the regression range.

Derick, would you have time to run a test against the following two builds for now? If the first build works fine and the second fails it's highly a regression from bug 496454. Otherwise we have to continue.

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2009/06/2009-06-15-03-mozilla-central/firefox-3.6a1pre.en-US.linux-i686.tar.bz2

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2009/06/2009-06-16-03-mozilla-central/firefox-3.6a1pre.en-US.linux-i686.tar.bz2

Comment 17

[Derick Eisenhardt]

Problem exists in both of those versions.

Comment 18

[Karl Tomlinson (:karlt)]

Looks like bug 496454 actually landed on the 14th PDT (even though it wasn't marked fixed til the 15th).
http://hg.mozilla.org/mozilla-central/pushloghtml?changeset=dd109d204029
So this would be the build with which to compare:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2009/06/2009-06-14-03-mozilla-central/firefox-3.6a1pre.en-US.linux-i686.tar.bz2

Comment 19

[Derick Eisenhardt]

Yep, that one did the trick. The 2009-6-14 nightly does Not have the problem.

Comment 20

[Karl Tomlinson (:karlt)]

Derick, thank you for your help.  I'll confirm this.  AFAIK there is little documentation to say exactly what a theme is expected to do, and so this is likely a Mozilla bug just because it doesn't behave in exactly the same way as GTK.  If there is only one theme affected, though (and that theme has a workaround), then, unless this theme is popular, this bug is probably not a high priority.