Send event when Weave is ready to register new engines

RESOLVED FIXED in 1.0

Status

Cloud Services
General
P3
enhancement
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Axel Nennker, Assigned: Mardak)

Tracking

unspecified
Points:
---
Bug Flags:
blocking-weave1.0 +

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

8 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.1.5) Gecko/20091102 Firefox/3.5.5
Build Identifier: 

The developer instructions on how to write and integrate a new engine give the advice to modify the original weave code. This is not practical for real world extensions that want to sync their data.

The other way to do it is to use:
Components.utils.import("resource://weave/service.js");
Weave.Engines.register(MyEngine); // MyEngine is your engine class

But it is not guaranteed that EngineManagerSvc already is instanciated.

So it is safe to create an event when the Engine Manager is ready to register engines. Extensions wanting to register engines can then wait for that event.

This is a small change. That should not stop the 1.0 version release.

Reproducible: Always
OS: Windows XP → All
Hardware: x86 → All

Updated

8 years ago
Severity: normal → enhancement
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P3
Target Milestone: --- → 1.1
(Assignee)

Updated

8 years ago
Assignee: nobody → edilee
Blocks: 534944
Flags: blocking-weave1.0+
Target Milestone: 1.1 → 1.0
(Assignee)

Comment 1

8 years ago
http://hg.mozilla.org/labs/weave/rev/e106915cbb70
Notify with "weave:service:ready" so observers can lazily load and wait to add engines, Weave UI.
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.