Audit custom steps to make sure they're reconfig safe

RESOLVED FIXED

Status

Release Engineering
General
P3
normal
RESOLVED FIXED
8 years ago
4 years ago

People

(Reporter: catlee, Assigned: bhearsum)

Tracking

Bug Flags:
needs-treeclosure +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [simple])

(Reporter)

Description

8 years ago
Any custom steps that refer to their base classes after the step is complete (e.g. in evaluateCommand) can break if a reconfig happens while the step is running.  The fix is to store a reference to the step's base class in the __init__ method, and then to use that reference in subsequent methods.

There are several steps where this isn't happening.  L10nVerifyMetaDiff for example.

Comment 1

8 years ago
Bug to be dealt with at due time.
Component: Release Engineering → Release Engineering: Future
Mass move of bugs from Release Engineering:Future -> Release Engineering. See
http://coop.deadsquid.com/2010/02/kiss-the-future-goodbye/ for more details.
Component: Release Engineering: Future → Release Engineering
Priority: -- → P3
(Reporter)

Updated

8 years ago
Whiteboard: [simple]
Assignee: nobody → lsblakk
(Assignee)

Comment 3

7 years ago
Lukas, I was touching so many steps in bug 505512 that I ended up doing this, so I'm going to steal this from you.
Assignee: lsblakk → bhearsum
(Assignee)

Updated

7 years ago
Flags: needs-treeclosure+
(Assignee)

Comment 4

7 years ago
Landed.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.