Last Comment Bug 532412 - Audit custom steps to make sure they're reconfig safe
: Audit custom steps to make sure they're reconfig safe
Status: RESOLVED FIXED
[simple]
:
Product: Release Engineering
Classification: Other
Component: Other (show other bugs)
: other
: x86 Linux
: P3 normal (vote)
: ---
Assigned To: Ben Hearsum (:bhearsum)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-12-02 08:18 PST by Chris AtLee [:catlee]
Modified: 2013-08-12 21:54 PDT (History)
3 users (show)
bhearsum: needs‑treeclosure+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments

Description Chris AtLee [:catlee] 2009-12-02 08:18:54 PST
Any custom steps that refer to their base classes after the step is complete (e.g. in evaluateCommand) can break if a reconfig happens while the step is running.  The fix is to store a reference to the step's base class in the __init__ method, and then to use that reference in subsequent methods.

There are several steps where this isn't happening.  L10nVerifyMetaDiff for example.
Comment 1 Armen Zambrano [:armenzg] (EDT/UTC-4) 2009-12-16 07:44:23 PST
Bug to be dealt with at due time.
Comment 2 Chris Cooper [:coop] 2010-02-15 07:52:56 PST
Mass move of bugs from Release Engineering:Future -> Release Engineering. See
http://coop.deadsquid.com/2010/02/kiss-the-future-goodbye/ for more details.
Comment 3 Ben Hearsum (:bhearsum) 2010-09-17 11:40:44 PDT
Lukas, I was touching so many steps in bug 505512 that I ended up doing this, so I'm going to steal this from you.
Comment 4 Ben Hearsum (:bhearsum) 2010-10-04 07:44:45 PDT
Landed.

Note You need to log in before you can comment on or make changes to this bug.