Closed
Bug 532412
Opened 15 years ago
Closed 14 years ago
Audit custom steps to make sure they're reconfig safe
Categories
(Release Engineering :: General, defect, P3)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: catlee, Assigned: bhearsum)
Details
(Whiteboard: [simple])
Any custom steps that refer to their base classes after the step is complete (e.g. in evaluateCommand) can break if a reconfig happens while the step is running. The fix is to store a reference to the step's base class in the __init__ method, and then to use that reference in subsequent methods.
There are several steps where this isn't happening. L10nVerifyMetaDiff for example.
|
||
Comment 1•15 years ago
|
||
Bug to be dealt with at due time.
Component: Release Engineering → Release Engineering: Future
|
||
Comment 2•15 years ago
|
||
Mass move of bugs from Release Engineering:Future -> Release Engineering. See
http://coop.deadsquid.com/2010/02/kiss-the-future-goodbye/ for more details.
Component: Release Engineering: Future → Release Engineering
Priority: -- → P3
|
Reporter | |
Updated•15 years ago
|
Whiteboard: [simple]
|
||
Updated•14 years ago
|
Assignee: nobody → lsblakk
|
Assignee | |
Comment 3•14 years ago
|
||
Lukas, I was touching so many steps in bug 505512 that I ended up doing this, so I'm going to steal this from you.
Assignee: lsblakk → bhearsum
|
|
Assignee | |
Updated•14 years ago
|
Flags: needs-treeclosure+
|
|
Assignee | |
Comment 4•14 years ago
|
||
Landed.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•