532442 - unable to zoom

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Panning/Zooming, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

when looking to install the ad block plus extension, I go to:
https://adblockplus.org/devbuilds/adblockplus/

I try to double click to zoom and it doesn't work.  N900, N810, Omnia2 with the latest 1.9.2 nightly build.

Comment 1

[Benjamin Stover (:stechz)]

What are you trying to zoom into?

Looking in firebug, there's no real column to zoom into anywhere except on the links (which works fine for me).  The only way to fix this is to have a general zoom-in if column zoom doesn't work.

Comment 2

[Aakash Desai [:aakashd]]

Ben, we chatted about this in regards to m.wikipedia.org so that we have a secondary zoom mechanism that does not rely on the content of the page. I thought that was fixed by either:

https://bugzilla.mozilla.org/show_bug.cgi?id=478038

or

https://bugzilla.mozilla.org/show_bug.cgi?id=524479

Comment 3

[Benjamin Stover (:stechz)]

It depends on what you mean.  Sure you can zoom in with the keyboard, but double tapping will still do nothing on sites like this one.

There are two options here:
1) Sometimes double tapping does nothing.
2) Double tapping always zooms in, even if it doesn't particularly zoom to something.

What do we really want?  And is the behavior we have now fine for 1.0?

Comment 4

[Stuart Parmenter]

I think we need to always zoom in

Comment 5

[Madhava Enros [:madhava]]

On the n900, CTRL-<up arrow> and CTRL-<down arrow> will zoom the whole in small
increments.  It's not ideal in that it (a) zooms from the upper left-hand
corner rather than the middle of the viewport and (b) relies on a hardware
keyboard, but it works and can help in these cases.

We were playing, earlier, with the idea of zooming a certain amount (say 30%,
to pull a number out of the air) when the user is currently at 100% zoom (full
page width, in other words) and if the double tapped area is full-screen width.
 So, in other words, this "dumb" zoom would happen when there's no structure to
zoom to (because the tapped area is already at screen width) but only if the
page is completely unzoomed in.  Otherwise, zoom works as it does now, so, after zooming in the 30%, double tapping again would take them back out to full page width, not take them in another 30%.

Comment 6

[Madhava Enros [:madhava]]

I should have said -- the adjustment to our zooming behavior I outlined in the second paragraph of the previous comment would be much preferable, in my opinion, to just always having double-tapping zoom the same arbitrary amount.  Structured zooming is very useful most of the time -- it's just in the case where everything is full-page-width that it breaks down.

Comment 9

[Benjamin Stover (:stechz)]

Attachment: Patch

Zooms 2x blindly at default zoom level, if nothing else can be done.

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 416199 [details] [diff] [review]
Patch

nits: change Browser -> this where appropriate

Comment 11

[Benjamin Stover (:stechz)]

Pushed as http://hg.mozilla.org/mobile-browser/rev/4a03aa5c95a5

Comment 12

[Aakash Desai [:aakashd]]

verified FIXED on build:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2b5pre) Gecko/20091209 Firefox/3.6b5pre Fennec/1.0b6pre