Closed
Bug 532453
Opened 15 years ago
Closed 15 years ago
Create gearman interface for cake
Categories
(addons.mozilla.org Graveyard :: Localization, enhancement, P1)
addons.mozilla.org Graveyard
Localization
Tracking
(Not tracked)
VERIFIED
FIXED
5.5
People
(Reporter: wenzel, Assigned: wenzel)
References
Details
Attachments
(1 file)
17.49 KB,
patch
|
clouserw
:
review-
|
Details | Diff | Splinter Review |
To run our L10n stats, we need a Gearman interface. It probably makes sense for us to have a generic library that we can make an svn external, and then have a Cake component to tie it to AMO with.
Assignee | ||
Comment 1•15 years ago
|
||
I made a simplified PHP interface to the Net_Gearman library here: http://viewvc.svn.mozilla.org/vc/libs/gearman-php/ For simple test cases, it works well already, but I am still having trouble hooking it up to Cake. Working on it.
Assignee | ||
Comment 2•15 years ago
|
||
All right, the external is already set and should be pulled in automatically. This patch contains the first two gearman-powered maintenance tasks for l10n. If you want to check this out, `pear install Net_Gearman-0.2.3`, then go to vendors/gearman-php, edit the config file to point to a gearman server and adapt the jobs directory path so it points to amo/bin/gearman-jobs (alternatively, you could just symlink that as gearman-php/jobs). The run `php gearman-worker.php` to start a single worker. Finally, running the maintenance tasks should dispatch jobs that are then picked up by the running worker.
Attachment #417680 -
Flags: review?(clouserw)
Comment 3•15 years ago
|
||
Comment on attachment 417680 [details] [diff] [review] Patch, rev. 1 There is a bunch of stuff referencing LOCALIZER_FEED_URL which doesn't exist. Please diff against trunk.
Attachment #417680 -
Flags: review?(clouserw) → review-
Assignee | ||
Comment 4•15 years ago
|
||
Sorry about that :( I need to check in what I have so far, so we can build on that.
Assignee | ||
Comment 5•15 years ago
|
||
I checked this into trunk, because it won't hurt others, and a new patch off the former trunk would be huge. Please check it out, and if it works well enough for you, we can mark this fixed.
Status: NEW → ASSIGNED
Assignee | ||
Comment 6•15 years ago
|
||
The interface exists now. QA: This is transparent to you. You'll be able to verify this bug once bug 536143 is in place and the localizer dashboard (bug 531883) shows (commit and statistical) data.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Comment 7•15 years ago
|
||
[11:42am] clouserw: as QA is concerned though, all you're really looking at is 1) Is the "Recent Activity" box filled in? 2) Are there bar charts with useful numbers on the right? [11:43am] clouserw: when looking at a URL like: https://preview.addons.mozilla.org/en-US/localizers/de
Comment 8•15 years ago
|
||
Wil: re: 2) in comment 7, I'm only seeing percentages in tooltips on hover; should I be seeing them as a bar-graph label, too?
Assignee | ||
Comment 9•15 years ago
|
||
You should see green and red parts -- bug not spelled-out numbers other than the tooltip.
Comment 10•15 years ago
|
||
(In reply to comment #8) > Wil: re: 2) in comment 7, I'm only seeing percentages in tooltips on hover; > should I be seeing them as a bar-graph label, too? no, they are fine
Thx; verified FIXED.
Status: RESOLVED → VERIFIED
Updated•8 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•