All users were logged out of Bugzilla on October 13th, 2018

Create gearman interface for cake

VERIFIED FIXED in 5.5

Status

P1
enhancement
VERIFIED FIXED
9 years ago
3 years ago

People

(Reporter: wenzel, Assigned: wenzel)

Tracking

unspecified
Dependency tree / graph

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
To run our L10n stats, we need a Gearman interface. It probably makes sense for us to have a generic library that we can make an svn external, and then have a Cake component to tie it to AMO with.
(Assignee)

Comment 1

9 years ago
I made a simplified PHP interface to the Net_Gearman library here: http://viewvc.svn.mozilla.org/vc/libs/gearman-php/

For simple test cases, it works well already, but I am still having trouble hooking it up to Cake. Working on it.
(Assignee)

Comment 2

9 years ago
Created attachment 417680 [details] [diff] [review]
Patch, rev. 1

All right, the external is already set and should be pulled in automatically. This patch contains the first two gearman-powered maintenance tasks for l10n.

If you want to check this out, `pear install Net_Gearman-0.2.3`, then go to vendors/gearman-php, edit the config file to point to a gearman server and adapt the jobs directory path so it points to amo/bin/gearman-jobs (alternatively, you could just symlink that as gearman-php/jobs). The run `php gearman-worker.php` to start a single worker. Finally, running the maintenance tasks should dispatch jobs that are then picked up by the running worker.
Attachment #417680 - Flags: review?(clouserw)
Comment on attachment 417680 [details] [diff] [review]
Patch, rev. 1

There is a bunch of stuff referencing LOCALIZER_FEED_URL which doesn't exist.  Please diff against trunk.
Attachment #417680 - Flags: review?(clouserw) → review-
(Assignee)

Comment 4

9 years ago
Sorry about that :( I need to check in what I have so far, so we can build on that.
(Assignee)

Comment 5

9 years ago
I checked this into trunk, because it won't hurt others, and a new patch off the former trunk would be huge. Please check it out, and if it works well enough for you, we can mark this fixed.
Status: NEW → ASSIGNED
(Assignee)

Updated

9 years ago
Blocks: 536141
(Assignee)

Updated

9 years ago
Blocks: 536143
(Assignee)

Comment 6

9 years ago
The interface exists now.

QA: This is transparent to you. You'll be able to verify this bug once bug 536143 is in place and the localizer dashboard (bug 531883) shows (commit and statistical) data.
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
[11:42am] clouserw: as QA is concerned though, all you're really looking at is 1) Is the "Recent Activity" box filled in?  2) Are there bar charts with useful numbers on the right?
[11:43am] clouserw: when looking at a URL like: https://preview.addons.mozilla.org/en-US/localizers/de
Wil: re: 2) in comment 7, I'm only seeing percentages in tooltips on hover; should I be seeing them as a bar-graph label, too?
(Assignee)

Comment 9

9 years ago
You should see green and red parts -- bug not spelled-out numbers other than the tooltip.
(In reply to comment #8)
> Wil: re: 2) in comment 7, I'm only seeing percentages in tooltips on hover;
> should I be seeing them as a bar-graph label, too?

no, they are fine
Thx; verified FIXED.
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.