532555 - Be stricter when looking for the name of the patch author

Status: RESOLVED FIXED

(Developer Services :: Mercurial: qimportbz, defect)

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Patch.__init__(): Compare both attacher and date, Warn when ambiguous

Not tested yet, but should be fine for (early) review.

Comment 2

[Serge Gautherie (:sgautherie)]

Attachment: (Av1a) Patch.__init__(): Compare both attacher and date, Warn when ambiguous [Checkin: See comment 5]

Av1, with a fixed "rename".

Comment 3

[Rob Arnold [:robarnold]]

Comment on attachment 415991 [details] [diff] [review]
(Av1a) Patch.__init__(): Compare both attacher and date, Warn when ambiguous
[Checkin: See comment 5]

>+      # Email domain may need to be retrieved/added manually...

Bugzilla 3.4 hides the domain? We could offer to log in to retrieve it? (the code to do that is still sitting on my machine somehwere). Perhaps this is fodder for another bug to support logins nicely. When that is added, this comment should be revisted.

Comment 4

[Serge Gautherie (:sgautherie)]

(In reply to comment #3)

> (From update of attachment 415991 [details] [diff] [review])
> >+      # Email domain may need to be retrieved/added manually...
> 
> Bugzilla 3.4 hides the domain? We could offer to log in to retrieve it? (the
> code to do that is still sitting on my machine somewhere). Perhaps this is
> fodder for another bug to support logins nicely.

Paul filed bug 534307 in the meantime ;-)

> When that is added, this comment should be revisted.

Maybe, though this is code to support the not-logged-in case which will (probably) remain supported.

Comment 5

[Serge Gautherie (:sgautherie)]

Comment on attachment 415991 [details] [diff] [review]
(Av1a) Patch.__init__(): Compare both attacher and date, Warn when ambiguous
[Checkin: See comment 5]


http://hg.mozilla.org/users/robarnold_cmu.edu/qimportbz/rev/9ae9c38dbcbe
Av1a, with s/email and date/date and email address/.