Be stricter when looking for the name of the patch author

RESOLVED FIXED

Status

Developer Services
Mercurial: qimportbz
--
minor
RESOLVED FIXED
8 years ago
3 years ago

People

(Reporter: sgautherie, Assigned: sgautherie)

Tracking

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

8 years ago
Created attachment 415753 [details] [diff] [review]
(Av1) Patch.__init__(): Compare both attacher and date, Warn when ambiguous

Not tested yet, but should be fine for (early) review.
Attachment #415753 - Flags: review?(tellrob)
(Assignee)

Comment 2

8 years ago
Created attachment 415991 [details] [diff] [review]
(Av1a) Patch.__init__(): Compare both attacher and date, Warn when ambiguous
[Checkin: See comment 5]

Av1, with a fixed "rename".
Attachment #415753 - Attachment is obsolete: true
Attachment #415991 - Flags: review?(tellrob)
Attachment #415753 - Flags: review?(tellrob)
Comment on attachment 415991 [details] [diff] [review]
(Av1a) Patch.__init__(): Compare both attacher and date, Warn when ambiguous
[Checkin: See comment 5]

>+      # Email domain may need to be retrieved/added manually...

Bugzilla 3.4 hides the domain? We could offer to log in to retrieve it? (the code to do that is still sitting on my machine somehwere). Perhaps this is fodder for another bug to support logins nicely. When that is added, this comment should be revisted.
Attachment #415991 - Flags: review?(tellrob) → review+
(Assignee)

Comment 4

8 years ago
(In reply to comment #3)

> (From update of attachment 415991 [details] [diff] [review])
> >+      # Email domain may need to be retrieved/added manually...
> 
> Bugzilla 3.4 hides the domain? We could offer to log in to retrieve it? (the
> code to do that is still sitting on my machine somewhere). Perhaps this is
> fodder for another bug to support logins nicely.

Paul filed bug 534307 in the meantime ;-)

> When that is added, this comment should be revisted.

Maybe, though this is code to support the not-logged-in case which will (probably) remain supported.
(Assignee)

Comment 5

8 years ago
Comment on attachment 415991 [details] [diff] [review]
(Av1a) Patch.__init__(): Compare both attacher and date, Warn when ambiguous
[Checkin: See comment 5]


http://hg.mozilla.org/users/robarnold_cmu.edu/qimportbz/rev/9ae9c38dbcbe
Av1a, with s/email and date/date and email address/.
Attachment #415991 - Attachment description: (Av1a) Patch.__init__(): Compare both attacher and date, Warn when ambiguous → (Av1a) Patch.__init__(): Compare both attacher and date, Warn when ambiguous [Checkin: See comment 5]
(Assignee)

Updated

8 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Product: Other Applications → Developer Services
You need to log in before you can comment on or make changes to this bug.