Closed
Bug 532806
Opened 16 years ago
Closed 16 years ago
OP_lookupswitch in LIR doesn't handle the default-only case
Categories
(Tamarin Graveyard :: Virtual Machine, defect)
Tamarin Graveyard
Virtual Machine
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: stejohns, Assigned: stejohns)
Details
Attachments
(1 file)
|
450 bytes,
patch
|
rreitmai
:
review+
edwsmith
:
superreview+
|
Details | Diff | Splinter Review |
A recent optimization trims items that are identical to the default case, but if all are trimmed then nothing is emitted for the opcode at all... what we should do is unconditionally jump to the default in this case.
|
Assignee | |
Comment 1•16 years ago
|
||
Attachment #415979 -
Flags: superreview?(edwsmith)
Attachment #415979 -
Flags: review?(rreitmai)
|
|
||
Updated•16 years ago
|
Attachment #415979 -
Flags: superreview?(edwsmith) → superreview+
|
|
||
Comment 2•16 years ago
|
||
needs a test case, too
|
|
||
Comment 3•16 years ago
|
||
Comment on attachment 415979 [details] [diff] [review]
Patch
good find.
Attachment #415979 -
Flags: review?(rreitmai) → review+
|
|
Assignee | |
Comment 4•16 years ago
|
||
pushed (with testcase) as changeset: 3258:8aaad35edfac
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
|
||
Updated•16 years ago
|
Assignee: nobody → stejohns
|
|
||
Updated•16 years ago
|
Status: RESOLVED → VERIFIED
Flags: in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•