Closed
Bug 532878
Opened 15 years ago
Closed 15 years ago
Call [super viewWillDraw] so that subviews can benefit, too
Categories
(Core :: Widget: Cocoa, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a1
| Tracking | Status | |
|---|---|---|
| status1.9.2 | --- | final-fixed |
People
(Reporter: mstange, Assigned: mstange)
References
Details
Attachments
(1 file)
|
921 bytes,
patch
|
jaas
:
review+
beltzner
:
approval1.9.2+
|
Details | Diff | Splinter Review |
The patch in bug 517804 didn't add a call to [super viewWillDraw] and I forgot to address Tom's comment about it when I relanded it. Let's do it now. With the call to super, viewWillDraw will also be called on subviews, and flushing subviews before drawing even fixes an observable bug: 1. Open the same page in two tabs, make one of these tabs the foreground tab. 2. Resize the window. 3. Click the other tab. Without this patch you'll sometimes see a brief white flash.
Attachment #416060 -
Flags: review?(joshmoz)
Attachment #416060 -
Flags: review?(joshmoz) → review+
|
Assignee | |
Comment 1•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/d193824b5855
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
|
|
Assignee | |
Updated•15 years ago
|
Attachment #416060 -
Flags: approval1.9.2?
|
||
Comment 2•15 years ago
|
||
Comment on attachment 416060 [details] [diff] [review] v1 a192=beltzner, followup fix that should have landed before
Attachment #416060 -
Flags: approval1.9.2? → approval1.9.2+
|
|
Assignee | |
Comment 3•15 years ago
|
||
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/b3a407caa02f
status1.9.2:
--- → final-fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•