532915 - Add mochitest test for "edit message as new" in compose window

Status: NEW

(Thunderbird :: Message Compose Window, defect)

Description

[David :Bienvenu]

Attachment: add start of tests

We don't seem to have any tests for the compose window. So this is a start...The attached tests don't work because, for some reason, the compose window thinks the window is dirty, and puts up a modal dialog when I try to close it. It doesn't do this when I do the exact same steps in the UI, so it's probably some mozmill oddity that will take a couple days to track down.

Comment 1

[Mark Banner (:standard8)]

So I've actually got small set of tests in bug 491921 that have done some compose window tests and have created a helper file for some of the functions (named slightly different to yours).

We should try and merge, although mine are still waiting on dmose's review at the moment...

Comment 2

[David :Bienvenu]

Yeah, we should merge these once dmose reviews it and it lands. I'm hoping all the timer stuff in wait_for_compose_window helps with the modal dialog on compose window close.

Comment 3

[David :Bienvenu]

Attachment: this adds a test for the memory corruption in edit message as new, and tries to get a bit in sync with standard8's compose tests

this almost works - I still get a close dialog when closing the edit message as new compose window, but we can worry about that when we merge with Standard8's patch.

Comment 4

[:aceman]

Magnus, can you see if this patch is of any value today? There seem to be some compose tests in mail/test/mozmill/composition (not compose-window as in the patch). Maybe this is already covered?

Comment 5

[Magnus Melin [:mkmelin]]

It's mostly obsolete. However we don't have a open_compose_window_with_edit in test-compose-helpers.js so we could add a small test that "Edit Messaege as New" works.

Comment 6

[:aceman]

OK, how do we know it worked?

Comment 7

[Magnus Melin [:mkmelin]]

We could just do the basics: check that the window comes up and that the content is what expected, attachments are there (if in original).

Comment 8

[Magnus Melin [:mkmelin]]

We do have some tests for it now. https://searchfox.org/comm-central/rev/45acec6df8379eb964d7a57f83c02dd97f588364/mail/test/browser/composition/browser_replyMultipartCharset.js#106