No error prompting for invalid email on weave sign up

RESOLVED FIXED in 1.2

Status

Cloud Services
Firefox Sync: UI
P2
minor
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: tchung, Assigned: zpao)

Tracking

unspecified
Points:
---
Bug Flags:
blocking-weave1.2 +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [WeaveTestday])

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
There's no UI error prompting the user when entering in an invalid email address.  We should at least indicate something there, because the "Continue" button remains disabled.   Users can easily think their problems is elsewhere (password, username), and not necessarily an invalid email address.  ...I know, the email address is obviously fluked in my example below, but we should still show an error message)

Repro:
1) install weave 1.0b3pre
2) create a new account page
3) enter in valid usernames, passwords, but a invalid email  (eg. "sdlkfj.com")
4) verify the "Continue" button remains grayed out, but no note saying email is invalid to the user.

Expected:
- some message saying you need a valid email address.  (esp since we're already checking valid ascii formatting on the client side)
(Reporter)

Updated

8 years ago
Whiteboard: [WeaveTestday]
(Reporter)

Updated

8 years ago
OS: Mac OS X → All
Hardware: x86 → All
This needs a string, so it's a 1.2 blocker.
Severity: normal → minor
Flags: blocking-weave1.2+
Priority: -- → P2
Target Milestone: --- → 1.2

Updated

8 years ago
Assignee: nobody → mconnor

Updated

8 years ago
Assignee: mconnor → paul
Created attachment 436345 [details] [diff] [review]
Patch v0.1

Now it does.
Attachment #436345 - Flags: review?(mconnor)
Whiteboard: [WeaveTestday] → [WeaveTestday][has patch][needs review mconnor]

Updated

8 years ago
Attachment #436345 - Flags: review?(mconnor) → review+

Comment 3

8 years ago
Comment on attachment 436345 [details] [diff] [review]
Patch v0.1

Hold on ;) Don't we need a conditional "" depending on the email status to clear out the message on a successful email?
Attachment #436345 - Flags: review+ → review?(edilee)

Updated

8 years ago
Attachment #436345 - Flags: review?(edilee) → review+

Updated

8 years ago
Whiteboard: [WeaveTestday][has patch][needs review mconnor] → [WeaveTestday][has patch][has review]
(In reply to comment #3)
> (From update of attachment 436345 [details] [diff] [review])
> Hold on ;) Don't we need a conditional "" depending on the email status to
> clear out the message on a successful email?

Per our chat on IRC, no, we're good. For future posterity, since we're hiding the row anyway, it doesn't matter. It we want to get picky, we could followup and clean up the usage of _setFeedbackMessage across callers.

Pushed http://hg.mozilla.org/labs/weave/rev/0017b82a9fd7
(forgot the extended commit message... oops)
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Whiteboard: [WeaveTestday][has patch][has review] → [WeaveTestday]
You need to log in before you can comment on or make changes to this bug.