532932 - No error prompting for invalid email on weave sign up

Status: RESOLVED FIXED

(Firefox :: Sync, defect, P2)

Description

[Tony Chung [:tchung]]

There's no UI error prompting the user when entering in an invalid email address.  We should at least indicate something there, because the "Continue" button remains disabled.   Users can easily think their problems is elsewhere (password, username), and not necessarily an invalid email address.  ...I know, the email address is obviously fluked in my example below, but we should still show an error message)

Repro:
1) install weave 1.0b3pre
2) create a new account page
3) enter in valid usernames, passwords, but a invalid email  (eg. "sdlkfj.com")
4) verify the "Continue" button remains grayed out, but no note saying email is invalid to the user.

Expected:
- some message saying you need a valid email address.  (esp since we're already checking valid ascii formatting on the client side)

Comment 1

[Mike Connor [:mconnor]]

This needs a string, so it's a 1.2 blocker.

Comment 2

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Attachment: Patch v0.1

Now it does.

Comment 3

[Ed Lee :Mardak]

Comment on attachment 436345 [details] [diff] [review]
Patch v0.1

Hold on ;) Don't we need a conditional "" depending on the email status to clear out the message on a successful email?

Comment 4

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

(In reply to comment #3)
> (From update of attachment 436345 [details] [diff] [review])
> Hold on ;) Don't we need a conditional "" depending on the email status to
> clear out the message on a successful email?

Per our chat on IRC, no, we're good. For future posterity, since we're hiding the row anyway, it doesn't matter. It we want to get picky, we could followup and clean up the usage of _setFeedbackMessage across callers.

Pushed http://hg.mozilla.org/labs/weave/rev/0017b82a9fd7
(forgot the extended commit message... oops)