532988 - Mac-specific search lists addon not supported on MAC

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Search, defect, P3)

Description

[krupa raj[:krupa]]

steps to reproduce:
1.In the advanced search panel select platform-MACOSX and hit enter
2.Notice the add-ons in the search results

expected results:
Add-ons not supported on MAC are not listed

actual result:
The first search result is the add-on "Qute" which is not supported on MACOSX

screencast:
http://screencast.com/t/MzA2Y2NiM

Comment 1

[Wil Clouser [:clouserw]]

We should only index the latest version of the add-ons in the search.

Comment 2

[Wil Clouser [:clouserw]]

Maybe related to 532309.

Comment 3

[Justin Scott [:fligtar]]

The issue in both this bug and bug 532309 seems to be that we index all versions of an add-on for compatibility, but the user is confused when they get results that don't seem to support what they're looking for.

We should:
* by default, only consider the latest version of the add-on in results
* add a checkbox in Advanced Search that says "Include old versions that fit this criteria" which, when checked, considers all versions
* in SERPs, if the matching version is an old version, the install button should be a link to the "old versions" page of the add-on and indicate the newest old version that matches.

Comment 4

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

(In reply to comment #3)
> The issue in both this bug and bug 532309 seems to be that we index all
> versions of an add-on for compatibility, but the user is confused when they get
> results that don't seem to support what they're looking for.
> 
> We should:
> * by default, only consider the latest version of the add-on in results
> * add a checkbox in Advanced Search that says "Include old versions that fit
> this criteria" which, when checked, considers all versions
> * in SERPs, if the matching version is an old version, the install button
> should be a link to the "old versions" page of the add-on and indicate the
> newest old version that matches.

Yes, we should consider only the latest version.

No, we should not add an extra checkbox.

Adding an extra checkbox complicates and already complicated UI.  Secondly we'd have to come up with a lot of extra document fields in the search index based on whether this checkbox is checked or not and a lot of business logic to choose which fields based on what checkbox.

Unless there's a huge demand from our users to support this, I'd say we keep search simple.

The use case of a user looking for some archived addon seems a bit edge-casey.  We should also not put efforts into making obsolete things discoverable.

Onward and upward.

Comment 5

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

These seem to be Mac-happy:

https://preview.addons.mozilla.org/en-US/firefox/search/?q=qute&cat=all&advancedsearch=1&as=1&appid=1&lver=3.6&atype=0&pp=20&pid=3&sort=&lup=

Fixed presumably via:

http://github.com/jbalogh/zamboni/commits/0a21890