533012 - add the ability to see all the administrative actions performed by a user

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, enhancement)

Description

[Reed Loden [:reed]]

Seems that the 'activity2' action wasn't ported from 3.2.x to 3.4.x. If I try to use it, I get "I don't recognize the value (activity2) of the action variable."

:(

Comment 1

[Dave Miller [:justdave]]

Undocumented feature, figured nobody used it but you... ;)

Looks like I was right.

I was planning on putting this back, just hadn't got around to it yet.

Comment 2

[Dave Miller [:justdave]]

This is something we probably ought to push upstream anyway.

Comment 3

[Reed Loden [:reed]]

Attachment: patch - v1

Crappy patch to add it back. Need to add UI for links and other stuff... plus, I don't like how I'm doing it.

Comment 4

[Dave Miller [:justdave]]

Comment on attachment 420011 [details] [diff] [review]
patch - v1

doesn't work.  I applied it on bugzilla-stage-tip just to try it out and confirm, and indeed, it doesn't.  The placeholders don't work for column names.  You end up putting a string in that spot instead of a column name, which then makes nothing match at all.

Comment 5

[Reed Loden [:reed]]

Attachment: patch - v2

How about this?

Comment 6

[Gervase Markham [:gerv]]

What did/does this actually do?

Gerv

Comment 7

[Dave Miller [:justdave]]

(In reply to comment #6)
> What did/does this actually do?

Allowed you to look at all of the changes a given user made to users, rather than all of the changes made to that user.  It was a way to audit the admin activities of a specific user, more or less. (although basically all it was good for was viewing group changes since we don't log much else yet).

Comment 8

[David Lawrence [:dkl]]

Attachment: Patch to show profile edit history for a user (v1)

Patch to make the viewing of changes made to another user not an invisible feature :)

dkl

Comment 9

[:glob ✱]

Comment on attachment 594835 [details] [diff] [review]
Patch to show profile edit history for a user  (v1)

i don't think "Edit History" is a good name for this feature, as it could easily be confused with "bug editing".  how about "Admin History"?


>+        my $temp = $activity_who;
>+        $activity_who = $activity_userid;
>+        $activity_userid = $temp;

no need for a temp variable:

($activity_userid, $activity_who) = ($activity_who, $activity_userid);


as a side note, the user history and this report are accessible to any user which has the ability to change group membership; i was expecting it would be limited to editusers members only.  thoughts?

Comment 10

[David Lawrence [:dkl]]

Attachment: Patch to show profile edit history for a user (v2)

Thanks for the review. New patch with suggested changes.

dkl

Comment 11

[:glob ✱]

Comment on attachment 595133 [details] [diff] [review]
Patch to show profile edit history for a user  (v2)

r=glob

Comment 12

[David Lawrence [:dkl]]

Committing to: bzr+ssh://[e-mail]/bmo/4.0
modified editusers.cgi
modified template/en/default/account/profile-activity.html.tmpl                                                                              modified template/en/default/admin/users/edit.html.tmpl
modified template/en/default/admin/users/list.html.tmpl
modified template/en/default/global/user-error.html.tmpl
Committed revision 8058.