533019 - Default Browser setting: Make strings localizable

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Alex Pakhotin (:alexp)]

Move hard-coded strings from browser.xul to preferences.dtd as it was originally.

Comment 1

[Alex Pakhotin (:alexp)]

Attachment: Fix

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

This patch looks good, but it cannot land until mobile-browser is branched or Fennec 1.0 is released. Therefore, I won't r+ until either of those situations occurs.

Comment 3

[Alex Pakhotin (:alexp)]

Can we land this one now?

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #3)
> Can we land this one now?

Not quite yet, but soon. We have other patches waiting too.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/85f85d86b25b

Comment 6

[Axel Hecht [:Pike]]

We're branched?

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #6)
> We're branched?

Nope. Fennec 1.0 has been shipped and we have a release tag in Hg we will build from if we need to release a security fix.

Comment 8

[Axel Hecht [:Pike]]

Guys, I have no idea what I'm supposed to do with this.

Does string freeze mean anything to you?