Closed Bug 533019 Opened 14 years ago Closed 13 years ago

Default Browser setting: Make strings localizable

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
ARM
Windows Mobile 6 Professional
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: alexp, Assigned: alexp)

References

(
URL
)

Details

Attachments

(1 file)

Fix
2.61 KB, patch
mfinkle
: review+
Details | Diff | Splinter Review 
Move hard-coded strings from browser.xul to preferences.dtd as it was originally.
Attached patch Fix — — Splinter Review 

        Attachment #416188 -
        Flags: review?(mark.finkle)

    
  
Assignee: nobody → alexp

    
    

    
  
This patch looks good, but it cannot land until mobile-browser is branched or Fennec 1.0 is released. Therefore, I won't r+ until either of those situations occurs.

    
    

    
  
Can we land this one now?

        Attachment #416188 -
        Flags: review?(mark.finkle) → review+

    
    

    
  
(In reply to comment #3)
> Can we land this one now?

Not quite yet, but soon. We have other patches waiting too.
Whiteboard: [fennec-checkin-post1.0]

    
  
Status: NEW → ASSIGNED

    
    

    
  
pushed:
http://hg.mozilla.org/mobile-browser/rev/85f85d86b25b
URL: Bug 533019 - Default Browser setting:...
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [fennec-checkin-post1.0]

    
    

    
  
We're branched?

    
    

    
  
(In reply to comment #6)
> We're branched?

Nope. Fennec 1.0 has been shipped and we have a release tag in Hg we will build from if we need to release a security fix.

    
    

    
  
Guys, I have no idea what I'm supposed to do with this.

Does string freeze mean anything to you?

    
  
Component: Windows Mobile → General
QA Contact: mobile-windows → general

          You need to log in
          before you can comment on or make changes to this bug.