53303 - fix or remove nsCRT::strdup to use the NS_ allocator

Status: RESOLVED DUPLICATE of bug 901820

(Core :: XPCOM, defect, P2)

Description

[Dan Mosedale (:dmosedale, :dmose)]

One type signature of nsCRT::strdup() calls nsMemory::Alloc() like one would 
hope.  Another calls PL_strdup() which only uses PR_Alloc under the covers.  
This latter setup misses the memory pressure observers entirely.  scc also 
pointed out that it could also cause other problems in an embedding case where 
nsMemory::Alloc() doesn't end up calling PR_Alloc under the covers.

This also brings up the question of whether other libraries in the Mozilla code 
base (eg png, gif, jpg, zip, ldap, js) should be instrumented to somehow use 
nsMemory under the covers as well.

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

Saw something in one of the status reports implying that Ed might be interested 
in this.  If not, sorry for spamming you and feel free to remove yourself.

Comment 2

[Michael Kohler [:mkohler]]

This is a mass change. Every comment has "assigned-to-new" in it.

I didn't look through the bugs, so I'm sorry if I change a bug which shouldn't be changed. But I guess these bugs are just bugs that were once assigned and people forgot to change the Status back when unassigning.