Closed
Bug 533087
Opened 15 years ago
Closed 14 years ago
"Flash the Download Manager if it is already open" logic is falsely reversed
Categories
(SeaMonkey :: Download & File Handling, defect)
SeaMonkey
Download & File Handling
Tracking
(Not tracked)
RESOLVED
INVALID
People
(Reporter: InvisibleSmiley, Assigned: InvisibleSmiley)
Details
Attachments
(1 file)
1.03 KB,
patch
|
neil
:
review-
|
Details | Diff | Splinter Review |
The "Flash the Download Manager if it is already open" checkbox is connected to a <preference> with inverted="true". Checking the checkbox label against the underlying pref browser.download.manager.focusWhenStarting shows that the inverted attribute is wrong there.
Assignee | ||
Updated•15 years ago
|
Assignee: nobody → jh
Status: NEW → ASSIGNED
Assignee | ||
Updated•15 years ago
|
Attachment #416269 -
Attachment is patch: true
Attachment #416269 -
Attachment mime type: application/octet-stream → text/plain
Attachment #416269 -
Flags: superreview?(neil)
Attachment #416269 -
Flags: review?(neil)
Attachment #416269 -
Flags: approval-seamonkey2.0.2?
Attachment #416269 -
Flags: approval-seamonkey2.0.1?
Assignee | ||
Comment 1•15 years ago
|
||
Comment on attachment 416269 [details] [diff] [review] remove inverted attribute Patch applies to branch as well. I'll let you guys decide whether it's too late for 2.0.1.
Comment 2•15 years ago
|
||
Comment on attachment 416269 [details] [diff] [review] remove inverted attribute > http://mxr.mozilla.org/mozilla-central/source/toolkit/components/downloads/src/nsDownloadProxy.h#101 The download manager is flashed if it is open and the pref is false.
Attachment #416269 -
Flags: superreview?(neil)
Attachment #416269 -
Flags: review?(neil)
Attachment #416269 -
Flags: review-
Attachment #416269 -
Flags: approval-seamonkey2.0.2?
Attachment #416269 -
Flags: approval-seamonkey2.0.1?
Assignee | ||
Comment 3•14 years ago
|
||
(In reply to comment #2) > The download manager is flashed if it is open and the pref is false. Better late than never: Confirmed with a fresh profile and version 2.0.3pre.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•