"Flash the Download Manager if it is already open" logic is falsely reversed

RESOLVED INVALID

Status

SeaMonkey
Download & File Handling
RESOLVED INVALID
8 years ago
8 years ago

People

(Reporter: InvisibleSmiley, Assigned: InvisibleSmiley)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
Created attachment 416269 [details] [diff] [review]
remove inverted attribute

The "Flash the Download Manager if it is already open" checkbox is connected to a <preference> with inverted="true". Checking the checkbox label against the underlying pref browser.download.manager.focusWhenStarting shows that the inverted attribute is wrong there.
(Assignee)

Updated

8 years ago
Assignee: nobody → jh
Status: NEW → ASSIGNED
(Assignee)

Updated

8 years ago
Attachment #416269 - Attachment is patch: true
Attachment #416269 - Attachment mime type: application/octet-stream → text/plain
Attachment #416269 - Flags: superreview?(neil)
Attachment #416269 - Flags: review?(neil)
Attachment #416269 - Flags: approval-seamonkey2.0.2?
Attachment #416269 - Flags: approval-seamonkey2.0.1?
(Assignee)

Comment 1

8 years ago
Comment on attachment 416269 [details] [diff] [review]
remove inverted attribute

Patch applies to branch as well. I'll let you guys decide whether it's too late for 2.0.1.

Comment 2

8 years ago
Comment on attachment 416269 [details] [diff] [review]
remove inverted attribute

> http://mxr.mozilla.org/mozilla-central/source/toolkit/components/downloads/src/nsDownloadProxy.h#101

The download manager is flashed if it is open and the pref is false.
Attachment #416269 - Flags: superreview?(neil)
Attachment #416269 - Flags: review?(neil)
Attachment #416269 - Flags: review-
Attachment #416269 - Flags: approval-seamonkey2.0.2?
Attachment #416269 - Flags: approval-seamonkey2.0.1?
(Assignee)

Comment 3

8 years ago
(In reply to comment #2)
> The download manager is flashed if it is open and the pref is false.

Better late than never: Confirmed with a fresh profile and version 2.0.3pre.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.