http://www.mozilla.org/contribute/ does not validate to its doctype

RESOLVED FIXED

Status

RESOLVED FIXED
9 years ago
6 years ago

People

(Reporter: Tobbi, Assigned: Tobbi)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

9 years ago
When doing a W3C HTML validation, mozilla.org/contribute does not validate correctly to its doctype. 

Results:
http://validator.w3.org/check?uri=http%3A%2F%2Fwww.mozilla.org%2Fcontribute&charset=%28detect+automatically%29&doctype=Inline&group=0&user-agent=W3C_Validator%2F1.654

Comment 1

9 years ago
Happy to fix this if there's a patch available.
(Assignee)

Updated

8 years ago
Assignee: nobody → tobbi.bugs
Status: NEW → ASSIGNED
(Assignee)

Comment 2

8 years ago
Created attachment 449567 [details] [diff] [review]
HTML5 compatibility patch

I think this patch should correct the problem!
Attachment #449567 - Flags: review?(david)
(Assignee)

Comment 3

8 years ago
Urgh, now that I see it: Does it make sense to remove the two ending </div>s in footer.inc.php or would it be better if I'd remove them in contribute/index.html?

Comment 4

8 years ago
Re question in comment #3, I haven't looked at the patch closely yet but if the div tags in the footer are a problem across the site I imagine it makes sense to update footer.inc.php.  If this is just a problem on this page, probably remove them in contribute/index.html.  Will wait to deal with patch until I hear back.
(Assignee)

Comment 5

8 years ago
I've seen that my patch is wrong. Other HTML files use the template as well and they pass the test. I'll submit a new one asap.
(Assignee)

Comment 6

8 years ago
Created attachment 449658 [details] [diff] [review]
v.2: Removing stray <div> ending tags in the index file itself
Attachment #449567 - Attachment is obsolete: true
Attachment #449658 - Flags: review?(david)
Attachment #449567 - Flags: review?(david)

Comment 7

8 years ago
I just checked in a change that seems to be working.

http://viewvc.svn.mozilla.org/vc?view=revision&revision=68427

Would be good to have the page and form verified to make sure nothing got busted.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Attachment #449658 - Flags: review?(dboswell)
Component: www.mozilla.org → General
Product: Websites → www.mozilla.org
You need to log in before you can comment on or make changes to this bug.