533222 - Code error in nsAppRunner.cpp rouge #elif gcc 4.4.1 causes error in compile now not warning

Status: RESOLVED DUPLICATE of bug 478843

(Toolkit Graveyard :: Build Config, defect)

Description

[Steven Christenson]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.5) Gecko/20091102 Firefox/3.5.5
Build Identifier: Thunderbird-2.0.0.12

When using gcc 4.4.2 on target: i686-pc-linux-gnu 
You get a compile time error saying that #elif has no expression and compile stops. 

Reproducible: Always

Steps to Reproduce:
1. download thunderbird source 
2. have gcc 4.4.1 installed for x86 
3. compile 
Actual Results:  
 nsAppRunner.cpp:1373:6 error: #elif with no expression.

Expected Results:  
Clean compile 

I suspect this used to be a warning and now its a hard error and thats why it wasn't caught before maybe not and its soemthing somone forgot to comment out. In the actual file mozilla/toolkit/xre/nsAppRunner.cpp you have the folowing at line 1373

#elif 
#error Oops, you need platform-specific code here
#endif 

     NS_ADDREF(*aResult - lf); 
     return NS_OK; 
} 


The problem is the #elif with nothing to test there. I commented it out and it got past this error. I do not know if this will cause problems using the program later. I will have to test it.  

It is possible you may need the exact options I used in my .mozconfig if so please ask and ill post it. I was using a system NSS and NSPR 
nss-3.12.4 
nspr-4.8.2

Comment 1

[Benjamin Smedberg]

Isn't this a dup of bug 478843, fixed on our interesting branches?

Comment 2

[Steven Christenson]

Hmmmmm indeed it is.. That is strange when I did a search for nsAppRunner.cpp and #elif I did not get that bug as a search result. Ill close this as a duplicate. Also is this fixed in the latest download yet seams like this bug was put in back in febuary...