Closed
Bug 533227
Opened 15 years ago
Closed 14 years ago
Mozmill-restart should support sending reports
Categories
(Testing Graveyard :: Mozmill, defect)
Testing Graveyard
Mozmill
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: whimboo, Assigned: mikeal)
References
Details
(Whiteboard: [qae-p1][mozmill-1.4])
At the moment sending reports for restart tests isn't implemented: http://github.com/mikeal/mozmill/blob/master/mozmill/__init__.py#L351 We should also support sending reports for this kind of tests.
Reporter | ||
Comment 1•15 years ago
|
||
I have marked this as blocking because it will not allow us to send test results to brasstacks and run one of the (still to write) gorgeous scripts from Mikeal, which will sync the results with Litmus.
Reporter | ||
Updated•15 years ago
|
Whiteboard: [qae-p1]
Assignee | ||
Comment 2•14 years ago
|
||
Fixed in reports branch. All the reporting logic is broken up now in to different instance methods. The change in structure allow for restart tests to implement reports in 4 or 5 lines of code. There isn't a single commit to point at. I forgot to pull from whimboo/reports before I started this patch so it took some rebase work and a few merge conflict patches to get everything working. pushed to mikeal/mozmill/tree/reports
Reporter | ||
Comment 3•14 years ago
|
||
I tried to run the tests to verify the fix but I'm not able to get those changes activated. After a git pull I even run the setup.py command but there is still the master version used. Mikeal, what do I have to do to run the tests with the branch version? I'm a bit surprised atm that I have those problems. Never had it before.
Reporter | ||
Comment 4•14 years ago
|
||
Ping, Mikeal?
Reporter | ||
Comment 5•14 years ago
|
||
Ok, I was able to fix my problem with the local Mozmill installation. I did a test-run with the reports branch and it failed. After the tests have been run Firefox is getting closed but mozrunner hangs: File "/usr/local/bin/mozmill-restart", line 8, in <module> load_entry_point('mozmill==1.3', 'console_scripts', 'mozmill-restart')() File "/Volumes/data/build/tools/mozmill/mozmill/__init__.py", line 547, in restart_cli RestartCLI().run() File "/Volumes/data/build/tools/mozmill/mozmill/__init__.py", line 534, in run super(RestartCLI, self).run(*args, **kwargs) File "/Volumes/data/build/tools/mozmill/mozmill/__init__.py", line 518, in run self._run() File "/Volumes/data/build/tools/mozmill/mozmill/__init__.py", line 489, in _run self.options.report) File "/Volumes/data/build/tools/mozmill/mozmill/__init__.py", line 408, in run_tests self.run_dir(d, report, sleeptime) File "/Volumes/data/build/tools/mozmill/mozmill/__init__.py", line 361, in run_dir self.stop_runner() File "/Volumes/data/build/tools/mozmill/mozmill/__init__.py", line 318, in stop_runner self.runner.wait(timeout=30) File "/Volumes/data/build/tools/mozrunner/mozrunner/__init__.py", line 403, in wait self.process_handler.wait(timeout=timeout) File "/Volumes/data/build/tools/mozrunner/mozrunner/killableprocess.py", line 239, in wait return group_wait(timeout) File "/Volumes/data/build/tools/mozrunner/mozrunner/killableprocess.py", line 224, in group_wait time.sleep(.5); count += .5
Reporter | ||
Comment 6•14 years ago
|
||
Trash my formerly comment. That was the usual pid problem again. After a restart it seems to work. I will run tests now.
Reporter | ||
Comment 7•14 years ago
|
||
Mikeal, I have tested normal and restart tests in a row now and it looks pretty fine! We should get this merged with the master and pushed to pyPI for a beta (together with all the other fixes like the Python callbacks).
Assignee: nobody → mikeal.rogers
Status: NEW → ASSIGNED
Reporter | ||
Comment 8•14 years ago
|
||
Merge happened with: http://github.com/mikeal/mozmill/commit/e61313e807c9c05908a604ea57a121a091e37735 I'll run tests tomorrow to check if the software update test reporting works well.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [qae-p1] → [qae-p1][mozmill-1.3.1]
Reporter | ||
Comment 9•14 years ago
|
||
Verified fixed on all platforms. I will file a follow-up bug for some refactoring work we have to do here so when sub-classing a Mozmill class will work more easily.
Status: RESOLVED → VERIFIED
Reporter | ||
Updated•14 years ago
|
Whiteboard: [qae-p1][mozmill-1.3.1] → [qae-p1][mozmill-1.4]
Updated•8 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•