533255 - xpcshell-tests fail on c-c with m-192: "Warning: Duplicate resource declaration for 'gre-resources' ignored."

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Description

[Mark Banner (:standard8)]

Attachment: Short Log

To "simplify" migration, bug 524216 added a resource declaration to toolkit/content/jar.mn as follows:

resource gre-resources resource://gre/res/

Now we're setting up builds for the 1.9.2 branch, we're seeing errors such as:

TEST-UNEXPECTED-FAIL | ../../mailnews/resources/logHelper.js | Error console says [JavaScript Warning: "Warning: Duplicate resource declaration for 'gre-resources' ignored." {file: "file:///builds/slave/macosx-comm-1.9.2-check/build/objdir/mozilla/dist/bin/chrome/toolkit.manifest" line: 1}] - See following stack:

These seem mainly to originate from gloda related tests. I can't see any duplicate resource declaration, so I expect this could be something to do with how we're loading things in.

The full short log is attached, which I think gives enough context.

Assigning to Andrew as he's probably going to have the best idea of what doing. This blocks us getting a 1.9.2 branch fully running (although we can start running up other things whilst we try to fix this).

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

Attachment: v1 expect the Duplicate resource declaration warning in the error console

logHelper.js tries to be helpful and shunts messages from the error console so that they are visible to log4moz and also kill the test.  This works better when we don't have expected warnings that always happen.

This patch ignores a string along the lines of gre-resources, but is not locked down tightly to gre-resources.

Note that this suggests that Thunderbird is always going to have the warning in its error console when on 1.9.2 which suggests that we might want to address the root (non-logHelper.js) problem in a different way.

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 417691 [details] [diff] [review]
v1 expect the Duplicate resource declaration warning in the error console

The strange thing is I don't actually see a duplicate resource definition warning in the error console when I run Thunderbird on gecko 1.9.2. So I've got no idea if we can really file a bug there or what on.

Anyway, I think the patch is reasonable. r=Standard8.

Comment 3

[Mark Banner (:standard8)]

I checked this in so that we could get some of the 1.9.2 test builders green before Christmas :-) :

http://hg.mozilla.org/comm-central/rev/5fdd17820ea7