533332 - [regression] "make -C mailnews xpcshell-tests" doesn't run composer tests

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Description

[Ben Bucksch (:BenB)]

Reproduction:
1. Run "make xpcshell-tests" (wait 20 minutes)
2. Run "make -C mailnews xpcshell-tests" (wait 5 minutes)

Actual result:
Step 1 runs the tests in mailnews/composer/test/ (and all Gecko tests and Mailnews test)
Step 2 does not the tests in mailnews/composer/test/ (although it does run the test in imap, mime, AB etc., but not in those for Gecko, as expected.)

Expected result:
- "make -C mailnews" builds everything in mailnews/
- "make -C mailnews xpcshell-tests" runs all xpcshell unit tests in mailnews/

Reason:
This seems to be a regression caused by bug 509367

Comment 1

[[e-mail]]

Attachment: Proposed patch

Comment 2

[Ben Bucksch (:BenB)]

I think the following patch is better than hacking around a hack.

Comment 3

[Ben Bucksch (:BenB)]

Attachment: Fix v2 - original fix for 509367 + standard8's suggestion [Checkin: See comment 8+9]

This is the patch from bug 509367 comment 1 plus Standard8's suggestion in the following comment, plus the Seamonkey change.

I think this is better, also because it allows composer to build in parallel.

Comment 4

[Ben Bucksch (:BenB)]

Attachment: Fix v1.1

If you must take the first idea, at least do it by including all of $(DIR), in case somebody adds things to the DIR line.

Comment 5

[[e-mail]]

Comment on attachment 416461 [details] [diff] [review]
Fix v2 - original fix for 509367 + standard8's suggestion
[Checkin: See comment 8+9]

I can't really review the interdiff between two of my patches...

Comment 6

[Serge Gautherie (:sgautherie)]

It looks like patch v2 is ready for check-in, isn't it?
Is this actually affecting c-1.9.1 only?

Comment 7

[Ben Bucksch (:BenB)]

I think so (not sure about sr).
I just didn't have time to look at it yet.

Comment 8

[Serge Gautherie (:sgautherie)]

Comment on attachment 416461 [details] [diff] [review]
Fix v2 - original fix for 509367 + standard8's suggestion
[Checkin: See comment 8+9]


http://hg.mozilla.org/comm-central/rev/5fdf1bd04492

Comment 9

[Serge Gautherie (:sgautherie)]

Comment on attachment 416461 [details] [diff] [review]
Fix v2 - original fix for 509367 + standard8's suggestion
[Checkin: See comment 8+9]


(In reply to comment #8)
> http://hg.mozilla.org/comm-central/rev/5fdf1bd04492

With added formatting and sorting improvements while there.

Comment 10

[Mark Banner (:standard8) (afk until 21st July)]

Comment on attachment 416461 [details] [diff] [review]
Fix v2 - original fix for 509367 + standard8's suggestion
[Checkin: See comment 8+9]

Not taking this on 3.0.1. There's no benefit to users, and the full xpcshell-tests do run in mailnews/compose so, worst case if a developer doesn't catch the failure on a post-1.9.1 branch, the tinderboxes will catch it.