533358 - ASSERTION FAILED: caught exception getting value for ``cmd.change-value.help''

Status: RESOLVED FIXED

(Other Applications Graveyard :: Venkman JS Debugger, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1.7pre) Gecko/20091207 SeaMonkey/2.0.2pre] (comm-1.9.1-win32-unittest/1260219994) (W2Ksp4)
{
vnk: init {** ASSERTION FAILED: caught exception getting value for ``cmd.change-value.help''
[Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIStringBundle.GetStringFromName]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://venkman/content/venkman-msg.js :: getMsgFrom :: line 115"  data: no]
}
when I enable Venkman in bug 504730.

Bug 396142 removed the "cmd.change-value.help" property...

"You are not authorized to access bug #396142." :-(

Comment 1

[James Ross]

The help was removed because the command could no longer be usefully used in the interactive session (arguments changed such that objects were needed), I believe, but this doesn't appear to have been correct - I was unfamiliar with this requirement of Vnk when reviewing it :(. Looking at other Venkman commands, it should have help added back (for code users, presumably).

Comment 2

[Serge Gautherie (:sgautherie)]

(In reply to comment #0)
> Bug 396142 removed the "cmd.change-value.help" property...
> "You are not authorized to access bug #396142." :-(

That was http://hg.mozilla.org/venkman/rev/406aa2c44ff8.

(In reply to comment #1)
> Looking at other Venkman
> commands, it should have help added back (for code users, presumably).

{
     1.2 +++ b/locales/en-US/chrome/venkman.properties

    1.23 -cmd.change-value.params  = <parent-value> <property-name> [<new-value>]
    1.24 -cmd.change-value.help    = Changes the value of the property named <property-name> of the jsdValue <parent-value>.  If the jsdValue <new-value> is specified, this will become the new value of the property, otherwise a dialog box is displayed, allowing the user to enter a new expression for the value.
    1.25 +cmd.change-value.params  = <jsd-value> <property-name> <expression> [<new-value>]
}

What should the new help text be?

Comment 3

[:Gijs (he/him)]

Attachment: Patch

Comment 4

[Serge Gautherie (:sgautherie)]

Comment on attachment 513048 [details] [diff] [review]
Patch

> cmd.change-value.label
>+cmd.change-value.help
> cmd.change-value.params

Nit: .help seems to usually be after .label and .params.

Comment 5

[Karsten Düsterloh]

Comment on attachment 513048 [details] [diff] [review]
Patch

r=me with .help moved after the .params.

Comment 6

[Justin Wood (:Callek)]

Note, SeaMonkey2.1 is in string freeze, so would be best if we can hold off this landing. Because of that I don't find this l10n-impact strong enough to break string-freeze, so not wanted.

Comment 7

[:Gijs (he/him)]

http://hg.mozilla.org/venkman/rev/bc430c9235af

Comment 8

[Robert Kaiser]

Just FYI, as no venkman release has been made since, we are still not shipping this change in SeaMonkey.