in i386 backend, some 8 and 16 bit loads assert inappropriately

VERIFIED FIXED in flash10.1

Status

Tamarin
Baseline JIT (CodegenLIR)
P2
normal
VERIFIED FIXED
8 years ago
8 years ago

People

(Reporter: Steven Johnson, Assigned: Steven Johnson)

Tracking

unspecified
flash10.1
x86
All
Bug Flags:
flashplayer-qrb +

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
Created attachment 416493 [details] [diff] [review]
Patch

LD8Zdm, LD8Zsib, LD8Sdm, LD8Ssib all assert if the displacement is outside the range 0...31 inclusive. This is a holdover from a long-ago misguded attempt to enforce ARM limitations on all architectures; there is no longer any good reason for this assert as any int32 offset is fine here.
(Assignee)

Updated

8 years ago
Attachment #416493 - Flags: review?(rreitmai)
(Assignee)

Updated

8 years ago
Attachment #416493 - Attachment is patch: true
Attachment #416493 - Attachment mime type: application/octet-stream → text/plain
Attachment #416493 - Flags: review?(nnethercote)
Attachment #416493 - Flags: review?(nnethercote) → review+

Updated

8 years ago
Attachment #416493 - Flags: review?(rreitmai) → review+
(Assignee)

Comment 1

8 years ago
pushed to nj-c in changeset:   1102:279dc4a95975
(Assignee)

Comment 2

8 years ago
Pretty sure that this has been pushed to all relevant repos, shall we close it?

Comment 3

8 years ago
mark fixed?
Assignee: nobody → stejohns
Status: NEW → ASSIGNED
Flags: flashplayer-qrb+
Priority: -- → P2
Target Milestone: --- → flash10.1
(Assignee)

Updated

8 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED

Updated

8 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.