533373 - nightly partial-generator broken (l10n repackaging used two different buildids)

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Nick Thomas [:nthomas] (UTC+12)]

Building patches for Firefox/mozilla-central/WINNT_x86-msvc/af/20091205042811
     => Updating to Firefox/mozilla-central/WINNT_x86-msvc/af/20091207044948
Touching /builds/nightly-partial-generation/aus/0//////complete.txt... done
Downloading http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2009/12/2009-12-07-04-mozilla-central-l10n/firefox-3.7a1pre.af.win32.complete.mar...
--16:10:43--  http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2009/12/2009-12-07-04-mozilla-central-l10n/firefox-3.7a1pre.af.win32.complete.mar
          => `to.mar'
Resolving ftp.mozilla.org... 10.2.74.10
Connecting to ftp.mozilla.org|10.2.74.10|:80... connected.
HTTP request sent, awaiting response... 200 OK
Length: 11,048,348 (11M) [application/octet-stream]

   0K ........ ........ ........ ........ ........ ........ 28%    4.21 MB/s
 3072K ........ ........ ........ ........ ........ ........ 56%    2.46 MB/s
 6144K ........ ........ ........ ........ ........ ........ 85%    2.82 MB/s
 9216K ........ ........ ........                           100%   12.85 MB/s

16:10:46 (3.38 MB/s) - `to.mar' saved [11048348/11048348]

done
Touching /builds/nightly-partial-generation/aus/0//////partial.txt... done
Downloading ...
wget: missing URL
Usage: wget [OPTION]... [URL]...

Try `wget --help' for more options.
create_partial_patch: 'wget -O from.mar ' returned non-zero! at /builds/nightly-partial-generation/app/patch-packager.pl line 737.

For some reason
/opt/aus2/build/0/Firefox/mozilla-central/WINNT_x86-msvc/20091205042811/af/complete.txt points to http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2009/12/2009-12-06-04-mozilla-central-l10n/firefox-3.7a1pre.af.win32.complete.mar, which does not exist. Same for ca, el, eo, mr and oc for the same win32 buildid.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Removed .../mozilla-central/WINNT_x86-msvc/20091205042811/{af,ca,el,eo,mr,oc}/ and it's back in action.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

It appears there was a problem with the first 6 builds for win32 l10n on 20091206, eg http://production-master.build.mozilla.org:8010/builders/Firefox%20mozilla-central%20win32%20l10n/builds/18719 thru 18724. Somewhow they managed to set a buildid property of 20091205042811, but use 20091206041852 and a 2009-12-06-... directory in the snippet, yet upload it to WINNT_x86-msvc/20091205042811. So perhaps we need an additional clean up step to remove an old build ?

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Another unusual thing, the m-c revision didn't change between 20091205 and 06 builds (because we had no checkins). No idea if that is related or not.

Comment 4

[Armen [:armenzg]]

I am not sure how this happened. The buildids are loaded with slightly different python modules but that should not be it.
Between "make ident" and generating the snippet the buildid loaded from application.ini did change. If "make unpack" did not unpack correctly both steps would have obtained the same buildid but they didn't. If "make wget" had not downloaded the right build then both buildids would be the same as well.

It seems that both steps pull the information from the same application.ini so I can't tell what happened here.
http://mxr.mozilla.org/mozilla-central/source/browser/locales/Makefile.in#287
@$(PYTHON) $(topsrcdir)/config/printconfigsetting.py             $(STAGEDIST)/application.ini App BuildID

which loads the file in here:
http://mxr.mozilla.org/mozilla-central/source/config/printconfigsetting.py#9:
c = configobj.ConfigObj(file)

http://mxr.mozilla.org/mozilla1.9.2/source/tools/update-packaging/generatesnippet.py#111
c.readfp(open(/e/builds/moz2_slave/mozilla-central-win32-l10n-nightly/build/mozilla-central/dist/l10n-stage/firefox/application.ini))
...
buildid = c.get("App", "BuildID")

I am not spending more time on this but we should see if this happens in the future.