533383 - Installer has to check available space and select the storage with enough free space

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect)

Description

[Alex Pakhotin (:alexp)]

Installer selects "\Program Files\Fennec" location by default for installation. If the main storage does not have enough free space, the installation will fail. It would make sense to check the space available, and select Storage Card instead, if it exists and has enough space.

Comment 2

[Alex Pakhotin (:alexp)]

Attachment: Patch

Check free space on all available mediums, select the one with enough space, or display a "Not enough storage" error message.

Comment 3

[Alex Pakhotin (:alexp)]

Attachment: Patch mobile

New message in setup.ini

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 426424 [details] [diff] [review]
Patch


>+    {
>+      WCHAR sMsg[c_nMaxErrorLen];
>+      int nSizeInMB = static_cast<int>(m_nUncompressedSize / 1024 / 1024 + 1);
>+      _snwprintf(sMsg, c_nMaxErrorLen, Strings.GetString(StrID_NotEnoughSpace), nSizeInMB);
>+      int nYesNo = MessageBoxW(m_hDlg, sMsg, Strings.GetString(StrID_WindowCaption), MB_YESNO|MB_ICONWARNING);
>+      bContinue = (nYesNo == IDYES);
>+    }
>+  }

Why allow the installation to continue? Is there any chance it'll succeed?

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 426426 [details] [diff] [review]
Patch mobile


>+NotEnoughSpace=There is not enough storage space on your device. You need %d MB available to install %MOZ_APP_DISPLAYNAME%. Do you still want to continue installation?
pretty much the same question as with the last patch. Madhava, what do you want to do here?

Comment 6

[Madhava Enros [:madhava]]

"Do you still want to continue installation?" seems like just letting people waste their time if we know there's not enough room, doesn't it?  Is there value there I don't get?

Maybe:
"There is not enough free space to install %MOZ_APP_DISPLAYNAME%. Make %d MB available and try installing again."

where %d is the additional amount (not just the total required) needed for the install to fit.

Comment 7

[Madhava Enros [:madhava]]

Actually - that's ambiguous.

Better:
"There is not enough free space to install %MOZ_APP_DISPLAYNAME%. Make an additional %d MB available and try installing again."

Comment 8

[Alex Pakhotin (:alexp)]

I've just realized - this new message about "additional space" might still be ambiguous if the device has two or more different kinds of storage - for example, internal storage and a memory card (some may also have an additional internal flash-memory area as well).
What space do we mean in the message? Main internal storage is more obvious of course, but what if the user prefers a memory card? It will not be clear from the message about internal memory how much he/she needs to free up on a flash card.
That's why I'd prefer to keep the total required amount.

Comment 9

[Alex Pakhotin (:alexp)]

Attachment: Patch v2

Not a major, but important change: moved free space check to a later stage as after Uninstall run it changes.

Comment 10

[Alex Pakhotin (:alexp)]

Attachment: New message text

Removed the question.
Made the message a bit similar to the standard system message about the low storage space.

Comment 11

[Doug Turner (:dougt)]

This year we mothballed windows mobile development.  See:

  http://blog.pavlov.net/2010/03/22/stopping-development-for-windows-mobile/

Marking bugs in the windows mobile / windows ce bucket as WONTFIX.