533432 - "Save All..." dialog cannot save files

Status: RESOLVED WORKSFORME

(Thunderbird :: Mail Window Front End, defect)

Description

[Glenn Sommer]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091106 Mandriva Linux/1.9.1.5-0.1mdv2010.0 (2010.0) Firefox/3.5.5
Build Identifier: 2.0.0.22 (20090625)

The "Save All..." dialog fails to save files if:
1: The files already exists in the folder you're trying to save to.
OR
2: If there's only one file to save.

Reproducible: Always

Steps to Reproduce:
1. Send an email with at least two attachments to yourself.
2. Save the files using File -> Attachments -> Save All...
3. Try to save the files AGAIN using the same method as above - in the SAME folder.
Notice when trying to save for the second time, the "Open" button has no effect at all.

note: If just ONE of the attachments are deleted before saving the second time, thunderbird will work as expected.

The Save All dialog also fails to save, if there's only ONE attachment to save. I don't know if this is related - but the symptoms are the same.
(Clicking the "Open" button has no effect at all. The dialog will not close, and the files will not be saved)
Actual Results:  
Thunderbird will not save the files the second time.

Expected Results:  
Thunderbird should ask for confirmation about overwriting the files.

This is tested with Thunderbird 2.0.0.22 and 2.0.0.23.
The latest Thunderbird 3 beta 4 has the same problem.

Comment 1

[Glenn Sommer]

I can confirm Thunderbird 3 RC2 still has these bugs.

Comment 2

[Ludovic Hirlimann [:Usul]]

Does this also happens in -safe-mode (http://kb.mozillazine.org/Safe_mode) ?

This sounds like two bugs. Once about overwriting multiple files. The other one about being confused in multiple save if one file is not already present, right ?

Comment 3

[Glenn Sommer]

Yes, the bug (both bugs?) is also present when using -safe-mode

Comment 4

[David von Oheimb]

On Linux, but not on WinXP, I can reproduce basically the same problem with both TB2 and TB3, yet I have a different interpretation of its context:

1. For a message with at least one attachment, select "Save All..." or "Detach All... " from the context menu in the attachments sub-window.
2. If you just try to click "Open" (without changing the default directory where the attachment(s) will be saved or detached to), nothing happens.
3. If you type in the Location field: "." (indicating the same directory) and hit Enter or click "Open", you get "Error creating directory: File exists".
4. If you click on any of the "Places" shown on the left, then navigate to any existing folder (even to the same one offered by default), then "Open" will succeed (regardless if the file to be saved already exists in the directory).

My strong suspicion is that this is a bug in GTK2, or maybe a wrong initialization of the filePicker, e.g. at SetDisplayDirectory(lastSaveDir)

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

Since 3.1 is mostly about providing a landing pad for Tb2 major update users, and this problem existed in Tb2, I don't think we'd block on it.  Adding wanted+, however.

Comment 6

[Markus W]

Can not confirm. 

Thunderbird/3.0.9/Linux i686

Saving the files as mentioned in the first comment to 
reproduce the bug opens a dialog "File exists. Overwrite? Yes/No".

Well, I can confirm what David mentioned in Comment 4 as 3rd point,
the dialog "File exists" opens up here, too.

Comment 7

[Glenn Sommer]

Just tested 3.0.5, and I can confirm the bug has been fixed.
I have no idea WHEN this bug was fixed - so I'll leave this open for a little while.
Maybe someone else can enlighten us - and provide the commit that actually fixed this issue ?

Comment 8

[David von Oheimb]

Meanwhile using Thunderbird 3.1.5, I can confirm that essentially all of the problems reported here are gone. 

The only issue that I (like Markus W) see remaining is a very minor one, namely, after selecting "Save All":
If you type in the Location field: "." (indicating the same directory) and
hit Enter or click "Open", you get "Error creating directory: File exists".

BTW, I find it generally a bit weird that when inserting in the Location field a name that does not yet exist at the current point in the file system, a new directory is implicitly created at this point with the given name (and the attachments are saved there). I'd find it cleaner if a new directory could only be created explicitly, using the "Create Folder" button.

Comment 9

[Ludovic Hirlimann [:Usul]]

WFM per comment 7