Fix mac and windows trunk builds

RESOLVED FIXED in 1.0b1

Status

Calendar
Build Config
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Fallen, Assigned: Fallen)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
Created attachment 416569 [details] [diff] [review]
Fix - v1

Trunk builds with MOZ_ENABLE_CANVAS3D and it seems we need to add some libs here. I do wonder why this isn't happening automatically in m-c though. Maybe we should think about some common makefile for all comm builds so we don't have to fix this for each project separately.
Attachment #416569 - Flags: review?(bugzilla)
(In reply to comment #0)
> Trunk builds with MOZ_ENABLE_CANVAS3D and it seems we need to add some libs
> here. I do wonder why this isn't happening automatically in m-c though. Maybe
> we should think about some common makefile for all comm builds so we don't have
> to fix this for each project separately.

If we were building with libxul, then we wouldn't need to do things like this. Having a common makefile or .mk option may be a better idea until we can do libxul builds. I'll have a think about it when I get time.
Attachment #416569 - Flags: review?(bugzilla) → review+
Comment on attachment 416569 [details] [diff] [review]
Fix - v1

Philipp, maybe you can remove the obsolete MOZILLA_1_9_1_BRANCH references before committing to comm-central.
(Assignee)

Comment 3

8 years ago
I'd prefer to do this after branching 1.9.2 in one step, to avoid extra work.

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/1667b2b71d7e>
and comm191: <http://hg.mozilla.org/releases/comm-1.9.1/rev/a376e38709de>

-> FIXED
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.0
(Assignee)

Updated

8 years ago
Target Milestone: 1.0 → 1.0b1
You need to log in before you can comment on or make changes to this bug.