Closed Bug 533502 Opened 10 years ago Closed 10 years ago

Idle crawler is too aggressive

Categories

(Firefox for Android Graveyard :: General, defect, blocker)

defect
Not set
blocker

Tracking

(fennec1.0+)

RESOLVED FIXED
Tracking Status
fennec 1.0+ ---

People

(Reporter: dougt, Assigned: stechz)

Details

Attachments

(2 files, 1 obsolete file)

Currently the idle crawler draws dirty tiles after 1s of inactivity.  When we increased this to 2s, we saw a noticeable perf improvement of page load time.  What i think we want is to have is two idle wait times.  

The first one should be used when we are not loading.  Basically the same as what kBrowserViewPrefetchBeginIdleWait does today).

The second idle wait should be used at page load time.  Its value should be much larger (like 10s).  We can derive a value by looking at the tp4 test load times.
tracking-fennec: --- → ?
tracking-fennec: ? → 1.0+
Assignee: nobody → mozbugz
Attached patch Patch v1 (obsolete) — Splinter Review
1. During loading, idle is 5 seconds
2. After load, idle is 1 second
3. drawWindow calls do not flush if page is loading
Assignee: mozbugz → webapps
Status: NEW → ASSIGNED
Attachment #416652 - Flags: review?
Attachment #416652 - Flags: review? → review?(mozbugz)
Attachment #416652 - Flags: review?(mark.finkle)
Attached patch PrefetchSplinter Review
Remove flushing optimization because we don't need it yet.  Bump up idle to 10 on loading.
Attachment #416652 - Attachment is obsolete: true
Attachment #416800 - Flags: review?(mozbugz)
Attachment #416652 - Flags: review?(mozbugz)
Attachment #416652 - Flags: review?(mark.finkle)
Comment on attachment 416800 [details] [diff] [review]
Prefetch


>+  /** Idle event handler. */
>+  observe: function observe(aSubject, aTopic, aUserIdleTime) {
>+    this._idleState = (aTopic == "idle") ? true : false;
>+    this._stop();
>+    if (this._idleState)
>+      this._start();
>+    else
>+      this._stop();
>+  },

nit: remove the first _stop();
Attachment #416800 - Flags: review?(mozbugz) → review+
Pushed http://hg.mozilla.org/mobile-browser/rev/80aad2fc31ba
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
http://hg.mozilla.org/mobile-browser/rev/48f9490d2d65

also removed the unused aggro variable.  we can add it back if it is ever needed.
You need to log in before you can comment on or make changes to this bug.