533502 - Idle crawler is too aggressive

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Doug Turner (:dougt)]

Currently the idle crawler draws dirty tiles after 1s of inactivity.  When we increased this to 2s, we saw a noticeable perf improvement of page load time.  What i think we want is to have is two idle wait times.  

The first one should be used when we are not loading.  Basically the same as what kBrowserViewPrefetchBeginIdleWait does today).

The second idle wait should be used at page load time.  Its value should be much larger (like 10s).  We can derive a value by looking at the tp4 test load times.

Comment 1

[Benjamin Stover (:stechz)]

Attachment: Patch v1

1. During loading, idle is 5 seconds
2. After load, idle is 1 second
3. drawWindow calls do not flush if page is loading

Comment 2

[Benjamin Stover (:stechz)]

Attachment: Prefetch

Remove flushing optimization because we don't need it yet.  Bump up idle to 10 on loading.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 416800 [details] [diff] [review]
Prefetch


>+  /** Idle event handler. */
>+  observe: function observe(aSubject, aTopic, aUserIdleTime) {
>+    this._idleState = (aTopic == "idle") ? true : false;
>+    this._stop();
>+    if (this._idleState)
>+      this._start();
>+    else
>+      this._stop();
>+  },

nit: remove the first _stop();

Comment 4

[Benjamin Stover (:stechz)]

Pushed http://hg.mozilla.org/mobile-browser/rev/80aad2fc31ba

Comment 5

[Doug Turner (:dougt)]

Attachment: differences between patch and push

Comment 6

[Doug Turner (:dougt)]

http://hg.mozilla.org/mobile-browser/rev/48f9490d2d65

also removed the unused aggro variable.  we can add it back if it is ever needed.