FixedMallocOpts should have a kCanFailAndZero value

VERIFIED FIXED

Status

Tamarin
Garbage Collection (mmGC)
VERIFIED FIXED
9 years ago
9 years ago

People

(Reporter: Steven Johnson, Assigned: Steven Johnson)

Tracking

Details

Attachments

(1 attachment)

433 bytes, patch
Tommy Reilly
: review+
Lars T Hansen
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

9 years ago
Purely convenience, to avoid having to do casting when you need both:
(Assignee)

Comment 1

9 years ago
Created attachment 416609 [details] [diff] [review]
Patch
Attachment #416609 - Flags: superreview?(lhansen)
Attachment #416609 - Flags: review?(treilly)

Updated

9 years ago
Attachment #416609 - Flags: review?(treilly) → review+

Comment 2

9 years ago
Comment on attachment 416609 [details] [diff] [review]
Patch

I'll approve this for now but the bug is really in the APIs: functions that take bit vectors of flags should not have a signature that calls for an enum type of the flags (even though that makes errors easier to catch).
Attachment #416609 - Flags: superreview?(lhansen) → superreview+
(Assignee)

Comment 3

9 years ago
pushed as changeset:   3287:d5328c9131b4
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED

Updated

9 years ago
Assignee: nobody → stejohns

Comment 4

9 years ago
Engineering work item.  Marking as verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.