533573 - Missing accessibility labels on the buttons in the "Select how you want to use Weave"

Status: RESOLVED FIXED

(Firefox :: Sync, defect, P1)

Description

[Marco Zehe (:MarcoZ)]

When setting up Weave for the first time, the buttons in the final screen of the wizard that says "Select how you want to start using Weave" have no accessible names. The result is that a screen reader such as NVDA will only speak the word "button". The labels should say something like "Merge", "Replace data on this computer", and "Select data on other devices" or something to that effect.

Comment 1

[Mike Connor [:mconnor]]

Marco, you're using 1.0b2, I assume? Can you retest with 1.0b3pre1? We're not using buttons anymore.

https://people.mozilla.com/~cbeard/weave/dist/latest-weave.xpi

Comment 2

[Marco Zehe (:MarcoZ)]

Mike, we're not picking up the description elements that are the children of each radio element. So here is my suggestion:

1. Give each description element an ID.
2. To each radio element add both an aria-labelledby and an aria-describedby attribute.
3. aria-labelledby points to the ID of the description that contains the bolded text.
4. aria-describedbz takes the IDs, separated by spaces, of the other description elements that belong to each radio. For the "merge" radio button, this looks like it has two of these, so it would be aria-describedby="id1 id2".

Comment 3

[Mike Connor [:mconnor]]

Awesome, thanks!

Taking, blocking, will have a fix in b3 final, but not pre2, which is going on the wire shortly.

Comment 4

[Mike Connor [:mconnor]]

http://hg.mozilla.org/labs/weave/rev/90dc7f54c13f
use aria attributes to make the radiobuttons accessible

Thanks again Marco!