533600 - Rewrite nsXPConnect::GetWrapperFor in terms of XPCWrappedNativeScopes.

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Pseudo-code for creating wrappers

This is what I'm going to implement here. I hope the pseudo-code is readable to other interested people. There's a cheat sheet at the top of it that helped me tremendously in the making of this pseudo-code.

One thing to note here: there isn't anything here that's tremendously expensive or that requires the JS stack (just the current global object). There are some questions in here because it isn't clear to me what should happen in:

var o = {};
o.p = o;
var w = new XPCSafeJSObjectWrapper(o);
w = w.p // Should w still be a SJOW? It's totally pointless.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: wip

There's still some work to do here: COWs & co need to learn about how to act like a SOW when asked to. But other than that, this should be complete. I should also be able to backport this patch to older branches and use it to fix some bugs on them.

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: patch v1

Comment 4

[Johnny Stenback (:jst)]

Comment on attachment 423097 [details] [diff] [review]
patch v1

- In CreateWrapperFromType():

+  if (hint & SOW) {
+    if (OBJECT_TO_JSVAL(obj) == *vp) {
+      if (!SystemOnlyWrapper::WrapObject(cx, scope, *vp, vp)) {
+        return JS_FALSE;
+      }
+    } else {
+      // TODO Write me!

Do we need to write this to land this patch?

r=jst if not.

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

That TODO is filled in in another patch. I was going to land them at the same time.

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

http://hg.mozilla.org/mozilla-central/rev/563a0f2f93c1