533665 - Avoid the need to build NSPR for L10N repacks

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Justin Dolske [:Dolske]]

Attachment: Patch v.1

L10N repacks need to build libmar in order to generate update data. Libmar pulls in a single header file from NSPR for a handful of familiar types, but this is causing build headaches for L10N repacks due to the way the environment. The investigation from bug 531275 seems to indicate that we have problems building the WinCE compiler wrappers when there's no objdir, which leads to problems building NSPR during the repack.

Armen says the plan is to convert the L10N bits to use a proper objdir + mozconfig soon, but this won't happen in time for 1.9.2. So I think the best fix to get things moving is this attached patch, which pulls in the typedefs needed from NSPR directly instead of using a #include.

We should then backout this change when the future L10N changes allow doing repacks in a normal build environment that doesn't give rise to this problem.

Comment 1

[Robert Strong (they/them - no direct email)]

Comment on attachment 416722 [details] [diff] [review]
Patch v.1

Looks fine / safe. r=me assuming this has been tested to work.

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 416722 [details] [diff] [review]
Patch v.1

a192=beltzner, I'm totally good with this, but we should figure out a way to track the "once we're doing the right thing..." part. New bug? To do?

Comment 3

[Armen [:armenzg]]

The work is tracked in our L10n priorities and we will cover this. I have also added the dependency.

Comment 4

[Justin Dolske [:Dolske]]

Pushed http://hg.mozilla.org/mozilla-central/rev/e41f3b73ee3e
Pushed to 192: http://hg.mozilla.org/releases/mozilla-1.9.2/rev/997d1e003a51

Comment 5

[Armen [:armenzg]]

I guess I should have added the comment in here.

I am hitting this in my l10n builds:
https://bugzilla.mozilla.org/attachment.cgi?id=417481
e:\builds\slave\mozilla-1.9.2-wince-l10n-nightly\build\mozilla-1.9.2\modules\libmar\src\mar.h(44)
: fatal error C1083: Cannot open include file: 'prtypes.h': No such file or
directory