533714 - Using width/height on a menu/panel affects normal layout

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Neil Deakin]

The following:

<panel height="200">...</panel>

causes 200 pixels of space in the normal layout to be allocated for the panel, even when closed. The expected behaviour is that the panel should take up no space when closed, but have a floating window 200 pixels high when open.

Comment 1

[(no longer active)]

This happens with the Inspect element on Mac:

http://grab.by/4XaA

And the inspector's panel has a height attribute set:

http://grab.by/4XaO

Comment 2

[Neil Deakin]

I think this is because the box layout code isn't skipping over the menupopup's placeholder frame and is setting its height. Alternatively, the placeholder frame should have an implementation of GetMinSize/GetPrefSize/GetMaxSize which returns (0,0)

Comment 3

[Neil Deakin]

Attachment: add simple implementations of GetMin/Pref/MaxSize

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 452031 [details] [diff] [review]
add simple implementations of GetMin/Pref/MaxSize

Why not 0x0 for the max size?

Comment 5

[Neil Deakin]

It causes the UI to mostly appear all scrunched up and misplaced, likely as no other constraints exists on other elements. The same would occur if (0,0) was used as the max size on other elements.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Oh, I see.  Because box layout is silly like that, ok.

Comment 7

[Neil Deakin]

http://hg.mozilla.org/mozilla-central/rev/76c076305bdf

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This patch added tests to the reftest directory layout/xul/base/reftest/ (originally added in bug 442228) which was not listed in the toplevel manifest, so they were never run in our automated testing.  I just did that:
https://hg.mozilla.org/integration/mozilla-inbound/rev/139eed687d77