"Share this" runs out of memory for popular add-ons

VERIFIED FIXED in 5.4

Status

addons.mozilla.org Graveyard
Public Pages
--
blocker
VERIFIED FIXED
9 years ago
2 years ago

People

(Reporter: wenzel, Assigned: wenzel)

Tracking

unspecified

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
Click on "share this", then any service, on:
https://addons.mozilla.org/en-US/firefox/addon/748

which redirects to:
https://addons.mozilla.org/en-US/firefox/addon/share/748?service=digg

And that's an empty page. Less popular add-ons can be shared successfully.

It is most likely an out-of-memory error in the share() function.
(Assignee)

Comment 1

9 years ago
Created attachment 416785 [details] [diff] [review]
Patch, rev. 1

Go, go, go!
Assignee: nobody → fwenzel
Status: NEW → ASSIGNED
(Assignee)

Comment 2

9 years ago
Making this a blocker so clouserw acknowledges it ;)
Severity: critical → blocker
Attachment #416785 - Flags: review+
(Assignee)

Comment 3

9 years ago
DONE! r57618
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Verified FIXED (was even able to briefly reproduce the problem on staging, before preview picked up from SVN).

https://preview.addons.mozilla.org/en-US/firefox/addon/748
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.