53394 - recent pages is ignoring pref

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[Kathleen :Brade]

I'm not sure who to give this bug to since I know Ryan is busy with school these 
days.

I've noticed a regression with Recent Pages in the editor... it is ignoring the 
pref I set.  Is this a known issue?

Comment 1

[Charles Manske]

What pref? The one for number of items? I had to rewrite Ryan's stuff 'cause
it wasn't working. But the current version should be getting the number of 
items from the pref. Maybe the pref isn't being set? I don't have a running
build yet, so can you please check if the value is being written to prefs.js.

Comment 2

[Kathleen :Brade]

Yes, the pref is definitely getting set.  It always has been.  This was working 
but apparently the code was backed out/rewritten.  Exactly what bugs were fixed 
with the old code being backed out/rewritten?  We'll want to retest them if we 
make any changes.

I see another bug in recent pages as well but I'll file it as a separate bug.

Comment 3

[Charles Manske]

Trivial to fix -- the pref is an INT not a STRING:
change:
  historyCount = gPrefs.CopyUnicharPref("editor.history.url_maximum");
to:
  historyCount = gPrefs.GetIntPref("editor.history.url_maximum");

Beppe: Can we get this one nsbeta+?

Comment 4

[rubydoo123]

charley has the fix in hand, will check in today

Comment 5

[Charles Manske]

checked in 9/21

Comment 6

[sujay]

verified in 9/22 build.