533951 - Undoing delete from unread search folder doesn't restore message in list

Status: RESOLVED WORKSFORME

(Thunderbird :: Folder and Message Lists, defect)

Description

[Joe Shaw]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6_1; en-US) AppleWebKit/532.5 (KHTML, like Gecko) Chrome/4.0.249.12 Safari/532.5
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.19) Gecko/20081209 Thunderbird/2.0.0.19 Mnenhy/0.7.5.0

I have an "unread" search folder (rule: Status isn't read).  Mails stay in that folder as I read them and they are marked read, which is great.

However, sometimes I delete a message (which has been marked read because I selected it) and then undo it.  I would like that mail to reappear in the message list even though it has been marked as read.

This appears to be a regression from Thunderbird 2, as I have often done this in the past.

Note that the deletion is undone -- the mail is in my INBOX -- it just isn't in my currently focused, unread search folder.

Reproducible: Always

Steps to Reproduce:
1. Go to unread search folder
2. Select a message
3. Delete the message
4. Undo
Actual Results:  
The message is restored from the Trash, although you can't tell this has happened unless you go to your inbox.  The message does not reappear in the search folder.

Expected Results:  
The message to reappear in the search folder, even though it may technically be unread.

Comment 1

[Joe Shaw]

Oops, sorry, the expected results should say, "even though it may technically be read".

Also under actual results, I could have stated things more clearly:  The message deletion is undone, although you can't tell this unless you go to your inbox.  The message does not reappear in the search folder.

Comment 2

[Ludovic Hirlimann [:Usul]]

This sounds like a filter issue.

Comment 3

[David :Bienvenu]

That's odd, because I have code for exactly that issue, and it works here. Are these imap messages or local messages? Are you viewing threads, or in a flat sort?

Comment 4

[Joe Shaw]

IMAP, and viewing threads.  I also just tried it without threads without success.

Comment 5

[Mitra Ardron]

I'm seeing the same thing - or a variation on it - and again, it used to work.

For example I just hit "Junk" and then "Undo" and can't find the message anywhere. It might be back in the inbox, but might not. (I've not got a filtered box, I'm showing all messages, sorted by threads). 

It seems to be correlated, but not necessarily, with a bug, where sometimes the index gets lost on a folder - i.e. I've noticed that if I hit the bug, and then go to the Junk folder, it has to rebuild the index.

Its somewhat intermittent, I don't have a repeatable case, though I've tried to repeat it.

Comment 6

[David :Bienvenu]

Mitra, which version of TB are you using?

Comment 7

[Mitra Ardron]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.1.5) Gecko/20091214 Shredder/3.0.1pre

Comment 8

[Wayne Mery (:wsmwk)]

I suggest this may be related to Bug 533513 Delete, Undo, Delete does not delete; requires 2nd Delete of message

Comment 9

[Wayne Mery (:wsmwk)]

can  you reproduce with version 3.1??

Comment 10

[Mitra Ardron]

See comment #5 - its not reproducable, but it does happen frequently. I'm on 3.3a4pre, and I just crashed mozilla doing deletes and undos! I presume the crash report is somewhere in the system.

Comment 11

[Wayne Mery (:wsmwk)]

bienvenu, 
I am able to reproduce comment 0, and it doesn't make sense to me that this should "work".

(In reply to David :Bienvenu from comment #3)
> That's odd, because I have code for exactly that issue, and it works here.
> Are these imap messages or local messages? Are you viewing threads, or in a
> flat sort?

do you mean that work in the case that mail was marked read? 
or only for the case that the message was still unread?

Comment 12

[David :Bienvenu]

(In reply to Wayne Mery (:wsmwk) from comment #11)
> bienvenu, 
> I am able to reproduce comment 0, and it doesn't make sense to me that this
> should "work".
> 
> (In reply to David :Bienvenu from comment #3)
> > That's odd, because I have code for exactly that issue, and it works here.
> > Are these imap messages or local messages? Are you viewing threads, or in a
> > flat sort?
> 
> do you mean that work in the case that mail was marked read? 
> or only for the case that the message was still unread?

no, it should work even if the message was marked read. That's the special code I added. What kind of saved search is this? cross folder or single folder?

Comment 13

[Wayne Mery (:wsmwk)]

(In reply to David :Bienvenu from comment #12)
> (In reply to Wayne Mery (:wsmwk) from comment #11)
> > bienvenu, 
> > I am able to reproduce comment 0, and it doesn't make sense to me that this
> > should "work".
> > 
> > (In reply to David :Bienvenu from comment #3)
> > > That's odd, because I have code for exactly that issue, and it works here.
> > > Are these imap messages or local messages? Are you viewing threads, or in a
> > > flat sort?
> > 
> > do you mean that work in the case that mail was marked read? 
> > or only for the case that the message was still unread?
> 
> no, it should work even if the message was marked read. That's the special
> code I added. What kind of saved search is this? cross folder or single
> folder?

Mitra?

Comment 14

[Mitra Ardron]

I can still repeat the original description. 

Note this is far from the worst problem with delete/undo which causes data loss if used offline and is probably one of the two most serious current TB bugs #857465
but maybe they are linked somehow.

Comment 15

[Wayne Mery (:wsmwk)]

(In reply to David :Bienvenu from comment #12)
>...
> no, it should work even if the message was marked read. That's the special
> code I added. What kind of saved search is this? cross folder or single
> folder?

Mitra, The question is, is your search folder targetted on an single folder?  Or multiple?

Comment 16

[Wayne Mery (:wsmwk)]

(In reply to David :Bienvenu from comment #12)
>...
> no, it should work even if the message was marked read. That's the special
> code I added. What kind of saved search is this? cross folder or single
> folder?

Joe, is your search folder targetted on an single folder?  Or multiple?

Comment 17

[Joe Shaw]

It's been six years. I have no recollection of the details.

Comment 18

[Wayne Mery (:wsmwk)]

(In reply to Joe Shaw from comment #17)
> It's been six years. I have no recollection of the details.

Presumably then, you no longer see this issue?

Comment 19

[Mitra Ardron]

Same - I can't repeat it , but then I don't use an multi-folder Unread folder any more 

I *do* still see the possibly related and MUCH more serious Data-loss bug where a Delete-Undo when offline loses the message #857465

Comment 20

[Wayne Mery (:wsmwk)]

Mitra, thanks for testing.
let's call this WFM.