533984 - Remove mention of Thunderbird in the description of the Lightning XPI

Status: RESOLVED FIXED

(Calendar :: Lightning: SeaMonkey Integration, enhancement)

Description

[Tony Mechelynck [:tonymec]]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.7pre) Gecko/20091210 Lightning/1.0b2pre SeaMonkey/2.0.2pre
- Build ID: 20091210000949

Current Lightning build: tinderbox-builds/comm-1.9.1/linux-xpi-linux/1260451075/lightning.xpi dated 2009-12-10 12:39 UTC

In my Addons Manager, the description for the Lightning extension is "An integrated calendar for Thunderbird". I suggest that (when the strings unfreeze) it be changed to "An integrated calendar for Thunderbird or SeaMonkey". After all, it _does_ work (quite good AFAICT) within the SeaMonkey MailNews window.

Comment 1

[Stefan Sitter [:ssitter]]

Instead of adding SeaMonkey to the description we should consider removing "Thunderbird". Otherwise someone might want to add e.g. Postbox or Icedove or Iceape in the future too.

Comment 2

[Tony Mechelynck [:tonymec]]

All right then; what about one of:
"A calendar extension for your mailer"
"A calendar in a mailer tab"
"A calendar for Tabmail"
"Integrate calendar and mail"
or something like that? Or even
"Recover your diary"?

Comment 3

[rsx11m]

Since SeaMonkey intends to ship Lightning by default with bug 516026 closing in, it should be added to the description. Postbox is not a Mozilla project (despite its roots there) and Linux distributions can easily patch install.rdf themselves as they see fit.

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

I agree to just remove it, or if we can use entities there then maybe even &brandShortName; A few suggestions:

"Calendaring & Scheduling capabilities for &brandShortName;"
"Events, Tasks and Email Scheduling"
"Calendar Integration for your Email"
"Because what would Email be without Calendaring?" ;-)

Comment 5

[rsx11m]

As a hybrid, how about this?

"Integrated Calendaring & Scheduling for your Email client"

I'm not sure about &brandShortName; if someone looks at the XPI isolated, it won't be clear which application is actually meant.

Comment 6

[rsx11m]

(In reply to Philipp Kewisch [:Fallen] from comment #4)
> if we can use entities there then maybe even &brandShortName; A few suggestions:

Won't work, I've tried it. There are two locations where this string is set, one is in install.rdf and the other in lightning.properties; the Add-ons Manager uses the latter which doesn't allow for any entities (i.e., an '&' and any other entity is shown verbatim).

Comment 7

[rsx11m]

Attachment: Possible patch

As a starting point, here is the patch with the string proposed in comment #5.
If nobody has any better idea, let's just go with it.

Comment 8

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8745173 [details] [diff] [review]
Possible patch

Review of attachment 8745173 [details] [diff] [review]:
-----------------------------------------------------------------

Lets do it, r=philipp. Once pushed, can you write a post on m.d.l10n explaining that this string has changed and that localizers need to adapt? This is one of the strings where we can't just change the entity. To avoid having to remind them in 6 weeks when this merges, we might want to push this to central+aurora.

Comment 9

[rsx11m]

Thanks, pushed to trunk as http://hg.mozilla.org/comm-central/rev/ba7f2327504b
comm-aurora is currently closed, I'll push there once it's open again.

Sure, I'll post in the l10n newsgroup later this morning.

Comment 10

[rsx11m]

https://hg.mozilla.org/releases/comm-aurora/rev/8f82f4732052

Comment 11

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Just to clarify, this is not the actual late-l10n we know, because we didn't change any entities. Nevertheless, this is a string change, so I'm moving it to the keyword. Thanks for pushing!

Comment 12

[rsx11m]

Yeah, whatever lands on comm-aurora with strings needs attention, was my thinking.
I've sent a message to the l10 mailing list, doesn't show up yet on mozilla.dev.l10n.

Comment 13

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Thanks! I believe that list is moderated, so it may take a few days to upload. If it doesn't by the end of the week let me know and I'll post it.

Comment 14

[rsx11m]

https://groups.google.com/forum/#!topic/mozilla.dev.l10n/aUHF_w3b2Y8 - it's there now.

Comment 15

[rsx11m]

Apparently the new Pootle system at https://mozilla.locamotion.org/ picked up the change even without modifying the property name. The old dashboard wasn't this smart, so that's progress!