53399 - PDF Support Problem: Crash in NPN_GetURL

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P2)

Description

[lmcquarr]

9/20 win build.

There is a feature of Acrobat that allows folks using web search engines
to get highlights of search hits in their pdf documents.  This feature
uses NPN_GetURL, which unfortunately crashes.  Here is the callstack:
GKPLUGIN! 603b75ec()
GKPLUGIN! 603b4e9b()
GKPLUGIN! 603b4d5b()
GKPLUGIN! 603b15fd()
NPN_GetURL(_NPP * 0x023582f8, const char * 0x025f15c8, const char * 0x00000000) 
line 190 + 20 bytes
OpenAuxStreams(_t_PDFXInstanceClientData * 0x0288dac0) line 1213 + 20 bytes
shimProcess(_t_PDFXInstanc


Here is how to reproduce:

1) Goto www.verity.com.
2) type in PDF in the search box on the first page and press enter
3) when your search results come up, select *any* pdf file  (the
first result is a PDF file titled P39991 - MK0212). 

4) When you view the PDF file, it comes up, and then the Acrobat
NS plug-in does a NPN_GetURL for the highlight data, and CRASH!

Comment 1

[sean echevarria]

confirming
attaching patch - call to get doc succeeded but there was no doc

Comment 2

[sean echevarria]

Attachment: proposed fix

Comment 3

[lmcquarr]

Thank you, [e-mail], for your fix!

Comment 4

[ekrock's old account (dead)]

Marking crash and P1 as this is a high profile partner. It's also high profile 
backwards compatibility as Acrobat is the #2 most widely-used plug-in on the web 
per Hotbot. Taking the liberty of marking [nsbeta3+][HAVE FIX] for Andrei and 
karnaze as Sean's provided a patch. Let's get this reviewed and checked in ASAP. 
Andrei, could you please review and also find whichever other reviewer we need 
per current check-in rules?

Comment 5

[av (gone)]

Fix looks good to me. r=av. I will submit it for approval.

Comment 6

[clayton]

Changing to P2.  After Friday we wouldn't stop ship for this one unless most 
Acrobat usage is blocked.

Comment 7

[av (gone)]

The patch is in. Thanks, Sean!

Comment 8

[shrirang khanzode]

verified on br windows 20000928. Does not crash anymore.