Closed Bug 534053 Opened 10 years ago Closed 10 years ago

Disabled add-ons should look different in the add-ons manager

Categories

(Firefox for Android Graveyard :: General, defect)

Fennec 1.1
x86
macOS
defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED
fennec1.0

People

(Reporter: madhava, Assigned: fabrice.desre)

Details

Attachments

(2 files, 2 obsolete files)

Disabled add-ons should be visually different from enabled ones in the add-ons manager list.  This happens a little bit already, in that disabled add-ons show the default green-puzzle-piece icon rather than a custom add-on, but this isn't enough given that some add-ons use that icon when enabled.

On the desktop, disabled add-ons are show with a faded out icon and a title in gray instead of black.  We could do something similar here, perhaps additionally desaturating the icon.
Attached patch patch (obsolete) — Splinter Review
Added CSS rules to set opacity at 0.25 for label, description and image of disabled add-ons, while not impacting buttons.

The wince stuff is replicated in browser-low.css and browser-high.css, even if both add-on sections are similar. Maybe it could all go in browser.css ?
Assignee: nobody → fabrice.desre
Attachment #417072 - Flags: ui-review?(madhava)
Attachment #417072 - Flags: review?(mark.finkle)
Attached image screenshot, with GeoGuide disabled (obsolete) —
Attached patch new patchSplinter Review
Uses opacity only for the image, and changing colors for the text :
black -> gray
gray  -> lightgray
Attachment #417072 - Attachment is obsolete: true
Attachment #417120 - Flags: ui-review?(madhava)
Attachment #417120 - Flags: review?(mark.finkle)
Attachment #417072 - Flags: ui-review?(madhava)
Attachment #417072 - Flags: review?(mark.finkle)
Comment on attachment 417120 [details] [diff] [review]
new patch

Based on the earlier screenshot and the description of the changes, it sounds good.  Would like to see an up-to-date screenshot though.
Attachment #417120 - Flags: ui-review?(madhava) → ui-review+
Attached image new screenshot
Madhava, here's an updated screenshot
Attachment #417073 - Attachment is obsolete: true
low risk patch

pushed:
https://hg.mozilla.org/mobile-browser/rev/d66ae9262670
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Post-B5
verified FIXED on builds:
Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2b5pre) Gecko/20091216 Firefox/3.6b5pre Fennec/1.0b6pre

and

Mozilla/5.0 (X11; U; Linux armv6l; Nokia N8xx; en-US; rv:1.9.3a1pre) Gecko/20091216 Firefox/3.7a1pre Fennec/1.0b5
Status: RESOLVED → VERIFIED
Flags: in-litmus?
Added to litmus: https://litmus.mozilla.org/manage_testcases.cgi?testcase_id=9834.
Flags: in-litmus? → in-litmus+
Attachment #417120 - Flags: review?(mark.finkle) → review+
Comment on attachment 417120 [details] [diff] [review]
new patch

I had r+ the earlier patch
You need to log in before you can comment on or make changes to this bug.