Closed Bug 534170 Opened 10 years ago Closed 10 years ago

Remove uses of -moz-mac-unified-toolbar and instead make all toolbars at the top of the window unified

Categories

(Core :: Widget: Cocoa, defect)

All
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.3a1

People

(Reporter: mstange, Assigned: mstange)

References

Details

Attachments

(1 file)

Attached patch v1Splinter Review
So simple, why didn't we do that in the first place?

I'm not removing the -moz-appearance value "-moz-mac-unified-toolbar" yet because I'm a little concerned about compatibility. I could be convinced though :)
Attachment #417079 - Flags: review?(joshmoz)
Attachment #417079 - Flags: review?(dao)
Attachment #417079 - Flags: review?(dao) → review+
If the -moz-appearance value was merely a compatibility concern then I'd argue we shouldn't keep it. This is only going on 1.9.3 and it is early, the perfect time to break compat if we're ever going to. Keeping compat here would merely leave redundancies for the sake of not making a decision right now.

If, on the other hand, having a toolbar somewhere other than at the top of the window would be useful to developers then it is a feature and not merely a compatibility concern. In that case we should keep it.

Markus noted on irc the use case of a toolbar at the bottom of a window, which Firebug might use. I think that makes this a feature, but we might not want to call it "unified." In any case, we should be clear about how to accomplish the desired UI and if possible not have redundancies in what is essentially the API for the toolbar.
Attachment #417079 - Flags: review?(joshmoz) → review+
There's another thing I didn't think about before: With this patch, -moz-appearance: toolbar will never draw a gradient toolbar when drawintitlebar="true" is set, but -moz-mac-unified-toolbar will. I'll file a bug on cleaning this up.

I pushed the patch as-is.
http://hg.mozilla.org/mozilla-central/rev/ef849db16c29
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
Blocks: 537273
Filed bug 537273.
Depends on: 537723
You need to log in before you can comment on or make changes to this bug.