When the build breaks because of Perl errors, this does not show up on the Tinderbox log.
MacPerl log is now included in the log if build fails. next step is to modify the parser so that specific line are detected as error and hyperlinked. Chris I'll need your help for that. Separate issue: I noticed that on the Mac tinderboxes, the log gets sent _only_ if the build fails. Windows & Unix send it even if build succeeds. I think we could we do the same for Mac, it's pretty easy and could turn out to be useful. What do you think ?
adding Terry to the cc list. Terry, according to cyeh, you're the best person to ask for recommendations regarding how to update the error parser to take care of this. Ideally, I'd like to have conditional parsing, so that if the string "Macperl returned an error" is found in the log then search for MacPerl specific error strings like: "# Can't create" "# Can't open" "### Can't find" and flag them. Actual logs for the RED Mac seamonkey builds today 4/22 between 3pm and 6pm will illustrate my point. Any help is appreciated.
this is fixed and we can close this, yes?
just setting a target milestone to get it off the radar of bugs with no milestones
No this is not fixed. I need to know how the error parser works. Right now, we don't have good hyperlinks for MacPerl Errors. I asked Terrry for help, as cyeh recommended, byt haven't heard from him yet.
setting target milestone for m6
So, in the tinderbox source (mozilla/webtools/tinderbox), there is a file called ep_mac.pl. This defines three routines: has_error() -- returns nonzero if the global variable $line has an error message in it. has_warning() -- returns nonzero if the global variable $line has an warning message in it. has_errorline() -- takes a line as parameter; if it defines the file and line number of an error, then it returns details about that in a bunch of global variables. So, you ought to be able to change it to detect your strings. Shouldn't this bug be reassigned to the Webtools product, Tinderbox component?
JJ, what kind of error strings should we be detecting for? Put it in this bug message, reassign the bug to terry and he can figure out the regular expression magic that I'm clueless about.
I listed the strings to highlight hereabove (04/22/99 19:05) If one of you (cyeh, terry) can show me the "magic", I'll be able to do it by myself next time!
terry is out. moving to m7.
I thought I did show you the "magic" -- I gave a pointer to the perl code in question. It's very short. I'm not willing to go code up the particulars here, because I do not understand the range of error messages that MacPerl might generate.
not critical for m7
moving to M9. we include the perl logs now though, right? if yes, then just close this.
not a m9 blocker, really an enhancement request. clearing milestone, setting severity
Status: ASSIGNED → RESOLVED
Last Resolved: 19 years ago
Resolution: --- → FIXED
Partially fixed. added a few error string to be flagged by the mac error parser. (mozilla/webtools/tinderbox/ep_mac.pl) Better fix will be to improve the MacPerl log and replace the standaed "MacPerl got an error" message by something more meaningful, This would have to happen in BuildCentral.
You need to log in before you can comment on or make changes to this bug.