give gozer (and maybe others) write permission to Thunderbird product-details files

RESOLVED FIXED

Status

--
major
RESOLVED FIXED
9 years ago
4 years ago

People

(Reporter: standard8, Assigned: chizu)

Tracking

Details

(Whiteboard: [tb30xwanted][tb31needed])

(Reporter)

Description

9 years ago
+++ This bug was initially created as a clone of Bug #532948 +++

The Thunderbird team need some kind of access to:

http://svn.mozilla.org/libs/product-details/thunderbirdDetails.class.php
http://svn.mozilla.org/libs/product-details/history/thunderbirdHistory.class.php

This is so that we can update these files with each new release (including security releases), without relying on MoCo folks to do it.

David Ascher suggested in bug 532948:

We could do two things:

1) a short-term fix, which is to have someone with permissions to that file do the change on MoMo's behalf.

2) a long-term fix, which is to change the layout in of http://svn.mozilla.org/libs/product-details/ to make it so that the data about thunderbird is pulled from specific revisions of an equivalent file on momo's svn repo.  

Specifically, make it so that:

  thunderbirdDetails.php is a symlink to thunderbird/thunderbirdDetails.php
  and thunderbird becomes a new svn:external to svn.m.o/momo/product-details

or some equivalent. (The above should mean that no other part of the app needs tweaking).

If we can do 2) soon we don't need to do 1).  If 2) is acceptable we can come up with a patch, as long as we can get review & deployment soon.


(I'm not totally sure this is the right component for this, so please move if necessary).
(Reporter)

Updated

9 years ago
Summary: Need to update Thunderbird product details php file (and figure out a decoupling so that momo folks can do it) → Figure out a way to allow MoMo folks to update the Thunderbird product details php file.
(Reporter)

Comment 1

9 years ago
Ping, any updates/thoughts? We're looking at doing a release in a couple of weeks so it would be good to get this figured out.
I put my thoughts in bug 532948 but to summarize:

What you describe here sounds overly complicated (symlinks?).  Why not just give write permission to the TB team to:

> http://svn.mozilla.org/libs/product-details/thunderbirdDetails.class.php
> http://svn.mozilla.org/libs/product-details/history/thunderbirdHistory.class.php

Then you can update it whenever you want.  It sounded like davida was fine with that and it's the fastest/easiest thing to do.

Comment 3

9 years ago
Since it's pretty restricted now, who should have access from the Thunderbird team? I assume gozer for sure. Anyone else?

Moving this to Server Ops. (IT: Be sure to read comment 2.)
Assignee: nobody → server-ops
Component: www.mozilla.com → Server Operations
Product: Websites → mozilla.org
QA Contact: www-mozilla-com → mrz
Summary: Figure out a way to allow MoMo folks to update the Thunderbird product details php file. → give gozer (and maybe others) write permission to Thunderbird product-details files
Version: unspecified → other

Comment 4

9 years ago
Dropping the severity, so it doesn't page while we are waiting for a list.
Severity: critical → major
I'd say gozer@mozillamessaging.com and mbanner@mozillamessaging (aka standard8, not sure what his LDAP account is).  We can add more if we need later.
(Reporter)

Comment 6

9 years ago
(In reply to comment #5)
> I'd say gozer@mozillamessaging.com and mbanner@mozillamessaging (aka standard8,
> not sure what his LDAP account is).  We can add more if we need later.

I suspect my LDAP account is bugzilla@standard8.plus.com
(Assignee)

Comment 7

9 years ago
SVN access for those files added.
Assignee: server-ops → thardcastle
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
(In reply to comment #2)
> I put my thoughts in bug 532948 but to summarize:
> 
> What you describe here sounds overly complicated (symlinks?).  Why not just
> give write permission to the TB team to:
> 
> > http://svn.mozilla.org/libs/product-details/thunderbirdDetails.class.php
> > http://svn.mozilla.org/libs/product-details/history/thunderbirdHistory.class.php
> 
> Then you can update it whenever you want. 

Catching up on bugmail, wanted to double-check something here. Is this file used anywhere by moco web properties (can I break stuff I don't control when I change it) ? If I want to make changes to these files, do I need to get a review, and if so, from who?

Otherwise, great.

Comment 9

9 years ago
I *believe* the only place it gets used is here:

  http://www.mozilla.com/en-US/products/download.html

That page only really appears to users when JS is off.

Eligible reviewers are clouserw and wenzel (probably morgamic in a pinch).
The files need to be at least parsable by mozilla.com or you may break downloads completely.

They are also used by addons.mozilla.org as well as potentially other sites.

In addition to changing the files, there is a new bonus step.  You've got to run `php -f export_json.php` before committing.  That will create .json files that you should commit along with your other changes.

Wenzel and I can review if you'd like.
(Reporter)

Comment 11

9 years ago
I'm a bit nervous that if for some reason we need to do a quick release and you guys aren't around for whatever reason, then we're going to be held up.

Is there a way we could automate this review?

The alternative option is that, as I believe mozilla.com & mozillamessaging.com (and presumably the other sites) all pull in specific versions of product-details, if we haven't got review from you and need to push things out, we update mozillamessaging.com and file a bug for mozilla.com saying that it needs review before updating it.

Which, as an aside, I guess you guys will generally want to know when to update mozilla.com for Thunderbird product-details anyway.
I can confirm that mozilla.com and mozilla-europe.org pull a specific revision of product-details on production, so worst case scenario is that you break the staging sites for those sites.
Everything should be pulling a revision, I can't speak for sites outside of Mozilla.  There isn't a way to automate the review.  Oh, and pascal can also do reviews. :)
(Reporter)

Comment 14

9 years ago
(In reply to comment #13)
> Everything should be pulling a revision, I can't speak for sites outside of
> Mozilla.  There isn't a way to automate the review.  Oh, and pascal can also do
> reviews. :)

Ok. FYI I have just filed bug 539936 to see if we can automate the generation of the details file. I'm not entirely sure it is possible and it may get broken from time to time, but I think it is worth a try. This will at least make the pre-review step easier ;-)
(Reporter)

Comment 15

9 years ago
I've just tried pushing this and got:

Transmitting file data ......svn: Commit failed (details follow):
svn: Access denied

My svn account is bugzilla@standard8.plus.com (see comments 5 and 6).

Trevor, can you take another look please?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 16

9 years ago
It seems that subversion can't allow access to specific files, only directories. The config just gets skipped, which is why you're getting permission denied. I've changed it to include all of product-details, which would be necessary anyways to commit the json files.

Can you commit now?
(Assignee)

Comment 17

9 years ago
Reopen if this still isn't working.
Status: REOPENED → RESOLVED
Last Resolved: 9 years ago9 years ago
Resolution: --- → FIXED
(Reporter)

Updated

9 years ago
Whiteboard: [tb30xwants][tb31needs] → [tb30xwanted][tb31needed]
Product: mozilla.org → mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.