534306 - Commit message is not being read

Status: RESOLVED FIXED

(Developer Services :: Mercurial: qimportbz, defect)

Description

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Attachment: Patch v0.1

Instead it's reading the "# User xxx" string as the commit message.

There's also a blank line at the top of the patch file. That's not so important, but the fix for that is the same place.

Comment 1

[Serge Gautherie (:sgautherie)]

Fwiw, I fully agree with this bug and patch.

Comment 2

[Rob Arnold [:robarnold]]

Comment on attachment 417169 [details] [diff] [review]
Patch v0.1

Looks good, thanks for the patch!

Comment 3

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Pushed http://hg.mozilla.org/users/robarnold_cmu.edu/qimportbz/rev/eac5fd7c6054

Comment 4

[Serge Gautherie (:sgautherie)]

(In reply to comment #3)
> Pushed http://hg.mozilla.org/users/robarnold_cmu.edu/qimportbz/rev/eac5fd7c6054

Just to double-check, was the first hunk actually part of this bug?

Comment 5

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

(In reply to comment #4)
> Just to double-check, was the first hunk actually part of this bug?

Good catch. Reverted that with http://hg.mozilla.org/users/robarnold_cmu.edu/qimportbz/rev/0d4c49a51c12